Bug#1100413: dpkg-source: Imprecise check for 3.0 (git) submodule existence

Daniel Gröber <[email protected]> Thu, 13 Mar 2025 16:25:16 +0100

Newsgroups	gmane.linux.debian.devel.dpkg.bugs
Message-ID	<20250313152516.o76rjme6yjgwmnxe__8261.07359477959$1741879648$gmane$org@darkboxed.org>

Package: dpkg-dev
Version: 1.21.22
Severity: normal
X-Debbugs-Cc: [email protected]

Hi Guillem, 

I'm trying to use source/format 3.0 (git) to share a git-bundle of some WIP
packaging changes with another DD.

The package in question rubs dpkg-source the wrong way:

     dpkg-source: error: git repository yosys uses submodules; this is not yet supported

However the packaging repo itself doesn't have submodules initialized so I
don't think there is any real problem.

Looking at Dpkg/Source/Package/V3/Git.pm the check is simply based on the
presence of the .gitmodules config file.

I believe the correct logic to check if submodules are actually in-use in
the current repo would be to check if `git submodule status` returns
non-empty output.

What do you think?

Thanks,
--Daniel

signature.asc (application/pgp-signature, 833 B)