Bug#1100187: dpkg-dev: Please drop pie-{compile,link}.spec also on x32 and elsewhere

Hi!

On Thu, 2025-12-18 at 11:39:51 +0200, Adrian Bunk wrote:
> On Sun, Sep 21, 2025 at 02:35:34PM +0200, John Paul Adrian Glaubitz wrote:
> > Agreed. Let's turn it off on architectures where it currently causes
> > more problems than it solves.

> Guillem, the patch below does:
> 
> 1. Disable PIE on x32, to fix this mixed half-PIE setup that breaks in 
> various places.
> 
> 2. Also disable PIE on m68k and sh4, these targets do not support PIE at 
> all making the spec files claim enabling PIE even though they don't.

Ah, sorry, meant to include this at the time, but I think I lost track of it!

> --- dpkg-1.23.1/scripts/Dpkg/Vendor/Debian.pm	2025-12-16 02:50:46.000000000 +0200
> +++ dpkg-1.23.1+test/scripts/Dpkg/Vendor/Debian.pm	2025-12-17 14:10:07.000000000 +0200
> @@ -373,9 +373,9 @@
>  
>      # Mask features that are not available on certain architectures.
>      if (none { $os eq $_ } qw(linux hurd) or
> -        any { $cpu eq $_ } qw(alpha hppa ia64)) {
> +        any { $cpu eq $_ } qw(alpha hppa ia64 m68k sh4 x32)) {
>          # Disabled on non-(linux/hurd).
> -        # Disabled on alpha, hppa, ia64.
> +        # Disabled on alpha, hppa, ia64, m68k, sh4, x32.
>          $use_feature{hardening}{pie} = 0;
>      }
>      if (any { $cpu eq $_ } qw(ia64 alpha hppa nios2) or $arch eq 'arm') {

Thanks for the patch and reminder, I've queued it now locally for my
next push, to be included for dpkg 1.23.3.

Regards,
Guillem