Re: Bug#1007905: transition: icu

Hi,

Am 15.04.22 um 08:57 schrieb László Böszörményi (GCS):
> On Fri, Apr 15, 2022 at 8:48 AM Rene Engelhard <[email protected]> wrote:
>> Am 13.04.22 um 17:52 schrieb Rene Engelhard:
>>> Am 13.04.22 um 17:24 schrieb László Böszörményi (GCS):
>>>> LibreOffice self-testing, especially its break iterator test fails for
>>>> the Lao language.
>>> https://cgit.freedesktop.org/libreoffice/core/commit/?id=263961306ede0656ebb7904034a2172615ce81d0
>> Nevermind, that one is already there.
>>
>> But it fails because it does != 70 and 71 still is affected.
>>
>> So we just need to extend it. Submitted it uptream in
>> https://gerrit.libreoffice.org/c/core/+/133063/1/i18npool/qa/cppunit/test_breakiterator.cxx
>> and will backport it to the 7.3.3 packages.
>   Your patch has a glitch. The U_ICU_VERSION_MAJOR_NUM check must be
> strictly lower than 70 for word boundary equal to nine. If it's ICU
> version 70 or higher, the else case should be hit. Ie:
> #if (U_ICU_VERSION_MAJOR_NUM < 70)
> is the correct check IMHO.

Ah, right, not enough coffee yet obviously. :)


Thanks for pointing this out.


Regards,


Rene