Re: css-validator ready for review and sponsorship

On 06/07/2025 19:46, Fab Stz wrote:
> Hi all,
> 
> I believe the package for css-validator is ready for review and sponsorship.
> Could someone please have a look?
> 
> https://salsa.debian.org/bastif/css-validator/

Hi Fabien,

I got a look at the package, here are my observations:

* the orig tarball generated by uscan is named 
css-validator_20250226+dfsg.orig.tar.xz, it's missing the 0~ prefix

* I would not bother to support jetty9 and tomcat10 since these packages 
are going to be removed in the near future. What about keeping only 
tomcat11 and jetty12 support?

* Instead of removing the external images in 
debian-cleanup-privacy-breach*.patch, they could be copied into the 
package to avoid broken images on the pages

It looks great overall, well done. The CLI is a bit weird, it doesn't 
accept file paths (only URLs, file: works) and outputs an obscure 
UnknownHostException error, but that's an upstream issue.

Emmanuel Bourg