Re: [py3porters-devel] Starting Points!

Alexandre Detiste <[email protected]> Thu, 28 May 2015 21:40:02 +0200

Newsgroups	gmane.linux.debian.devel.lsb,gmane.linux.debian.devel.python.py3porters
Message-ID	<2217745.nLAGD5X8jR@antec>

Le jeudi 28 mai 2015, 18:28:20 Alexandre Detiste a écrit :
>>> Dear lsb-release maintainers,
>>> 
>>> I'd like to propose a patch that enable Python3 support in lsb-release;
>>> based on what is done in Ubuntu since 2011.
>>> That would also solve these two bugs: #719063 & #761954

...and it's done.

The trickiest bit was this one:

-    C_env = os.environ.copy(); C_env['LC_ALL'] = 'C'
+    C_env = os.environ.copy(); C_env['LC_ALL'] = 'C.UTF-8'

The regression tests helped much here.

Can someone review this ?

https://github.com/a-detiste/lsb/commit/e4a31dd5f26e2aca65b58f47c2367049e8e3d9de

> > lsb_release is Python 3 in Ubuntu:
> > 
> > % head -1 /usr/bin/lsb_release 
> > #! /usr/bin/python3 -Es
> > 
> > Please start with that when porting the version in Debian.
> > -Barry

But they use advaced 2to3 trickery + sed magic
in debian/rules to achieve that :-|,
so I just picked the usefull bits and
did a one-off conversion to Python3.

Alexandre

signature.asc (application/pgp-signature, 819 B)