Bug#660790: lsb-base: log_warning_msg does not respect leading spaces

tags 660790 +wontfix
thanks

Hi Luca, and thanks for your bugreport,

Le 21.02.2012 22:42, Luca Capello a écrit :
>
> As you can see, the leading space is not respected.  I think this is
> because log_warning_msg calls log_begin_msg, which actually uses
> `/bin/echo -n "$@"` instead of adding a leading space before $@, as in
> log_progress_msg.  The latter is IMHO more correct, given that there is
> no *begin* message to be displayed.
> 
> However, this breaks other init scripts like rsync:
> 
> --8<---------------cut here---------------start------------->8---
>    120    reload|force-reload)
>    121          log_warning_msg "Reloading rsync daemon: not needed, as the daemon"
>    122          log_warning_msg "re-reads the config file whenever a client connects."
>    123          ;;
> --8<---------------cut here---------------end--------------->8---
> 
> So I do not really how this should be solved :-(

As is documented in lsb-base's README.Debian:

> This package also includes the LSB-specified logging functions:
>
> log_success_msg message
> log_failure_msg message
> log_warning_msg message
>
> These functions *do not* comply with Debian policy and should only be
> used by LSB packages.

So, openvpn (and rsync probably), should rather use the
log_action_begin_msg / log_action_end_msg pair (or the log_action_msg)
instead of those.

Hence tagging as "wontfix" as the documentation explicitly recommends
against using those functions. Now, this makes me wonder about
investigating and mass-filing bugs against init scripts making use of
them. Doh.

I hope this gives a honest answer to your bug.

Salutations,

OdyX

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQGcBAEBAgAGBQJPVzaxAAoJEIvPpx7KFjRVNRsL/3Nmb0KTiqZg7iMYlJDRUJbE
BlBiW7/ZOEj0eNjx7FA+aHa3/7PE1JwXzE2+jCzWFaBLOBdZPJ+XdbKPivK74VFM
c519YHW//3pILnw0qO1OJsqach1wDqSkaD7Hv6osTyqVKoNt5tMS5z48+i9PJrm7
TZzFDksqVtdfwLI0iIc2vJ1zxbuk4wqDx7Igw85w1uhb8teyPSgLG5NeSNW7kDMz
cSumfA5gqvQPlEQVImq4mGV9KiqE+dW4VRONqZmNhEJVjOoJiln5PtXOcVGcKR0z
my0g2NdZ54HdPha3mc2Dw34R8kkxE92hQiRFCPSjO0K5merWCWvJLGeyATTROxaD
8PsL981NuQzRNB2Miw6+1Ln+PG24kzzzWvl1O90cahJwHSxoPNtC4VSaOVFqThwm
9+2RvpjXJM8dgyof8/sRbub+L2zv0jVKSYGQNEVh/ZBhdkpPVXd+QayaAhTyDIwH
ef2FUO5t8rxZZegZhCsZiU98GGoXazwQF14Y+pfKHA==
=qnk1
-----END PGP SIGNATURE-----