Re: libcifpp updated, new soname, review requested

Hi Maarten,

Maarten L. Hekkelman, on 2023-09-14:
> There is a new version of libcifpp in salsa. Based on a new upstream and
> with lots of documentation. This package also has a new SONAME and therefore
> my kind request: could someone with the proper privileges review this
> package and upload it.

Thank you for your time and efforts on the continuous
maintenance of the libcifpp.  Since the SONAME bump will
introduce a round trip through NEW, I focused my review on
copyright pickiness, so it does not have to go through several
review cycles by ftpmaster.  Let's try to make it a single
round:

 1. The two following files have been introduced in version 5.2
    and would need dedicated entries in d/copyright since they
    declare being licensed under Boost Software License 1.0
    (careful not to make a single paragraph, as copyright
    holders are not exactly the same, although a concatenation
    of holders of both files may be tolerable):

        cmake/GetGitRevisionDescription.cmake
        cmake/GetGitRevisionDescription.cmake.in

 2. The holder of the following file went back in time in 2021,
    but the stamp in d/copyright doesn't go as far in the past:

        cmake/VersionString.cmake

    Reading further, these go as far as 2020:

        include/cif++/pdb/pdb2cif.hpp
        include/cif++/utilities.hpp
        src/pdb/pdb2cif_remark_3.hpp

    So it might be worth extending the range of dates for all
    files to 2020-2023 to be on the safe side in my opinion.

There could be other issues, as I have only reviewed through the
source differences since version 5.0.7.1, but that may be a good
start.

Please also have a look at lintian warnings and informational
messages, and see whether the noise could be reduced a bit.  For
instance, I spent some time on bash-term-in-posix-shell until I
noticed it was a false positive, so it might be worth wrapping
up an override, commented with a justification why the situation
is so.  Also, the standards version can probably be bumped to
the current 4.6.2[1].

[1]: https://www.debian.org/doc/debian-policy/upgrading-checklist.html#version-4-6-2

Hope this helps,
-- 
  .''`.  Étienne Mollier <[email protected]>
 : :' :  gpg: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/2, please excuse my verbosity
   `-    on air: The Healing Road - Birdbrain's Travels Part 1

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEj5GyJ8fW8rGUjII2eTz2fo8NEdoFAmUEjV8ACgkQeTz2fo8N
Edpi6w//RgjGp+nfkW7CRH2ZKxJA8Cz3S6KXadCBMJQNQsZ700vTj4HVNPJQ6dmB
lg01h8T6dN5RuZ2WBAHcWtn/juz1TLaHw01plzpAlJY/YJplKy9hPxxecZdYlTOg
ruZMqdRYZ7CI+p7TWqM41TxKuiBySvUGzdJ2eON1EsdY5U5zDTtJQ5maPZKqt39V
yMTpgF8xZ9/6/uHMxTDHcgRnlAZtmWVFP5IKJBfqM1grggBoR+YVCwil0YIMxMJl
mudL6RE8mtvzoNAQSb5G1oODum5MNCdOkvbvt5UwaZODBb3ECkhfJa0zCUKVQc9C
SV4pT749ofQzBWSBh2Wx89eqJIvZnK8tsDK4Xgqi4KleqRI7ltYOqcSVFVjU8TzA
XF3QAwW5s06z0z+54Dhh1bV5PmriWE8QRwfTYwNOmq5dLzBW68bW3SzYz7PAP+PK
Sxhzet7tbcTi496L6LaETGd2/zEApZWLBZe2nKLzmjid4PpoQ7g2nORsKPYxBZ+I
qdpP1j1Ysr6ybkAGypTcGS2gtibrqxE46GqytXNeuXXW50QFSjZqFWmRyOg3i+Dm
5NUgrUcrcVVT7rgMyEGcmvD+CqWKBYEdRJ+lWBDgszFcsDgAQ1pa2hUlTCLVHFk8
ekTLEBwhzFpaCfOXnjpvbTuBUBdjngYEXWNyQ92D5hhM4Q6a/j0=
=Bfn9
-----END PGP SIGNATURE-----