Re: Request for review:added autopkgtest for king

Hello Harish,

Le 29/05/2025 à 21:34, harish chavre a écrit :
> Hi Team,
> 
> i have added autopkgtest  for package king [0].
> kindly review and share your feedback.

Thanks a lot for improving the king package!

I am quite confident the ``superficial'' restriction can be removed: a 
classic king input file is read and treated, also the test invokes java, 
which supposes the command line is correctly read...
You could try to invoke ``king'' instead of ``java -jar 
/usr/share/java/king.jar'' to also test the file we ship in /usr/bin.

But what about the license of the example.kin file you shipped in 
debian/tests? Certainly this should be clarified and then the package 
will be fit IMO.

> 
> [0] https://salsa.debian.org/med-team/king/-/tree/master/debian/tests? 
> ref_type=heads <https://salsa.debian.org/med-team/king/-/tree/master/ 
> debian/tests?ref_type=heads>
> 
> Regards,
> Harish
> 

All the best,

-- 
Pierre

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEM8soQxPpC9J9y0UjYAMWptwndHYFAmg7aQsACgkQYAMWptwn
dHbmwA/+O1BQ0rav4q6mbBW0/yQvQKzmhVDM2ixEKyaWRddTrJI+V2tLyBb8jPlk
RxqOT4IU1hLMAdPKS34GriY5G/Je7cEd/nJCq2jsmKkXaptddXgzOqC6sgzV/ee8
smdHRDsQNmww8iFd6NR3FlsdwvMVDI/SCmHafs56c5Lt0lgVw0fSK5HtjLIS/aQy
VF3zXT8pKAxd7P2dDTh50eOzIY4mYjjhM8hCXcTQpoyW6d1KMlHSNJg0MHC+SBcy
jf3REZNuUhMYZxuPHbJpmdDfmZSBqb689450HOqNXzwbLCCwkAM7PGxplY2gBHUT
+B7kQZnPy/PR1Y1kG4ck8ggmI2rNdt9+kOrQzQN4PcC/x8vHZQGZVvBQ2z3unchR
Wo3HZi1zTzTDBqt2VEGCV19AhhsUpnDAYTaiDtEg/O7Dn8uOFUziiwO/u+J6b4eF
RSsCXVin4u7B6AnLj63/CeSqLYMIwr8CrvkI5fqazomYA6Nw7YNvLWEs+xyi+fIH
emOY0TwB4F2Bg6lh91/lCAPy0HrfccZ41UYkV8iUgyFB8qexDDM6aKKOg+Jyuh65
3Hf5GKvKFSb0KJ89qWNF7sCJvEI4svqmzyDkYHR+u9Ya69c8+S/Cw4LcLbloznHe
91WKyELg1qhlY1budf/Cf7jdPa3h2a3+BhS/bPCyOYQAN8zoU7Q=
=y4mA
-----END PGP SIGNATURE-----