Re: Request for review of autopkgtest for dicomscope
harish chavre <[email protected]> Thu, 19 Feb 2026 10:48:22 +0000 (UTC)
| Newsgroups | gmane.linux.debian.devel.medical |
|---|---|
| Message-ID | <[email protected]> |
------=_Part_165680_1611597277.1771498102334
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Hi ,
Thanks for the review and the helpful feedback.
I have fixed the autopkgtest PID handling and removed Priority optional and=
Rules Requires Root=C2=A0 from d/control as suggested. The updated changes=
are pushed to Salsa. Please re review the changes.
One quick question, since this is a packaging only change, should I add a c=
hangelog entry using dch or leave the changelog unchanged.
Thanks for the guidance,
Harish
On Saturday, 14 February 2026 at 12:17:06 am IST, =C3=89tienne Mollier =
<[email protected]> wrote: =20
=20
hi harish,
> I have added autopkgtest coverage for the dicomscope package
> and pushed the work to Salsa[0]. The earlier test issue and
> warning are resolved.=C2=A0Kindly review it and let me know if any
> adjustments are needed.
> [0] :https://salsa.debian.org/med-team/dicomscope/-/tree/master/debian/te=
sts?ref_type=3Dheads=C2=A0
Thanks for your investigations in getting better autopkgtest
coverage for Debian Med packages!=C2=A0 I looked up your changes,
plus your question from the Matrix channel:
>> Should I ignore this type of warning that occurs while
>> testing packages ,even after the tests pass?
>> tmp/autopkgtest.Hb1m12/build.YWw/real-tree/debian/tests/run-unit-test: l=
ine 25: kill: (95245) - No such process
I see the test is derived from similar autopkgtests relying on
starting graphical applications within an Xvfb X server, like
can be seen in edfbrowser[1].=C2=A0 To me, the intent of such test is
to make sure that the graphical application is capable of idling
without immediate crash.=C2=A0 Therefore, having lost the process
before the kill command is invoked may be symptomatic of the
graphical application having crashed early and should be
investigated.=C2=A0 That said, the evaluation of $program_pids does
capture a pid (95245), which means there is something running
few milliseconds earlier, or the pid is improperly captured.
[1]: https://salsa.debian.org/med-team/edfbrowser/-/raw/master/debian/tests=
/run-unit-test?ref_type=3Dheads
I have run the autopkgtest with a full `ps aux` output and a
`set -x` invocation, resulting in an output like:
=C2=A0=C2=A0=C2=A0 + ps aux
=C2=A0=C2=A0=C2=A0 USER=C2=A0 =C2=A0 =C2=A0 =C2=A0 PID %CPU %MEM=C2=A0 =C2=
=A0 VSZ=C2=A0 RSS TTY=C2=A0 =C2=A0 =C2=A0 STAT START=C2=A0 TIME COMMAND
=C2=A0=C2=A0=C2=A0 [=E2=80=A6]
=C2=A0=C2=A0=C2=A0 unshare=C2=A0 =C2=A0 =C2=A0 20=C2=A0 0.0=C2=A0 0.0=C2=A0=
4592=C2=A0 3368 ?=C2=A0 =C2=A0 =C2=A0 =C2=A0 S=C2=A0 =C2=A0 18:28=C2=A0 0:=
00 /bin/bash /tmp/autopkgtest.fKYQHc/build.iHv/src/debian/tests/run-unit-te=
st
=C2=A0=C2=A0=C2=A0 unshare=C2=A0 =C2=A0 =C2=A0 21=C2=A0 0.0=C2=A0 0.0=C2=A0=
2688=C2=A0 1884 ?=C2=A0 =C2=A0 =C2=A0 =C2=A0 S=C2=A0 =C2=A0 18:28=C2=A0 0:=
00 /bin/sh /usr/bin/xvfb-run --auto-servernum /usr/bin/dicomscope /usr/shar=
e/dicomscope/reports/reportsi.dcm
=C2=A0=C2=A0=C2=A0 unshare=C2=A0 =C2=A0 =C2=A0 32=C2=A0 0.2=C2=A0 0.0=C2=A0=
28708 22076 ?=C2=A0 =C2=A0 =C2=A0 =C2=A0 S=C2=A0 =C2=A0 18:28=C2=A0 0:00 X=
vfb :99 -screen 0 1280x1024x24 -nolisten tcp -auth /tmp/xvfb-run.tbuoOC/Xau=
thority
=C2=A0=C2=A0=C2=A0 unshare=C2=A0 =C2=A0 =C2=A0 35 10.7=C2=A0 0.0 21074700 1=
20684 ?=C2=A0 =C2=A0 Sl=C2=A0 18:28=C2=A0 0:03 java -Xms128M -Xmx16384m -ja=
r /usr/share/java/DICOMscope.jar /usr/share/dicomscope/reports/reportsi.dcm
=C2=A0=C2=A0=C2=A0 unshare=C2=A0 =C2=A0 =C2=A0 79=C2=A0 0.0=C2=A0 0.0=C2=A0=
6792=C2=A0 3976 ?=C2=A0 =C2=A0 =C2=A0 =C2=A0 R=C2=A0 =C2=A0 18:29=C2=A0 0:=
00 ps aux
=C2=A0=C2=A0=C2=A0 ++ ps aux
=C2=A0=C2=A0=C2=A0 ++ awk '/^unshare.*dicomscope/ {print $2}'
=C2=A0=C2=A0=C2=A0 ++ xargs
=C2=A0=C2=A0=C2=A0 + local 'program_pids=3D21 35 82'
=C2=A0=C2=A0=C2=A0 ++ awk '-vORS=3D ' '/^unshare.*[X]vfb/ {print $2}'
=C2=A0=C2=A0=C2=A0 ++ ps aux
=C2=A0=C2=A0=C2=A0 ++ xargs
=C2=A0=C2=A0=C2=A0 + local xvfb_pids=3D32
=C2=A0=C2=A0=C2=A0 + '[' -n '21 35 82' ']'
=C2=A0=C2=A0=C2=A0 + kill 21 35 82
=C2=A0=C2=A0=C2=A0 /tmp/autopkgtest.fKYQHc/build.iHv/src/debian/tests/run-u=
nit-test: line 27: kill: (82) - No such process
My impression is that the $program_pids captures too many pids
and you probably want to make the awk invocation in the pipeline
to capture more precisely the java DICOMscope.jar invocation.
$xvfb_pids does not have this problem.=C2=A0 Maybe something like
that will do?
=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 local program_pids=3D"$(
=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ps aux \
=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | awk "/^$USER"'.* java .*DI=
COMscope.jar/ {print $2}' \
=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | xargs
=C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 )"
Also, please avoir `|| true` after the tests, as this would
prevent catching real issues if dicomscope were to actually
crash during autopkgtest.=C2=A0 Instead, you may like to implement a
meanigful error message like you may see on edfbrowser's
autopkgtest.=C2=A0 This will facilitate the reading and diagnostic of
future autopkgtest failures by just looking at the log, instead
of having to investigate things by hand from the ground up.
Other than that, you may like to drop Priority: optional and
Rules-Requires-Root: no, as they are now default properties.
Please adjust dicomscope accordingly and ping back when you're
done, so someone can review your changes.
Have a nice day,=C2=A0 :)
--=20
=C2=A0 .''`.=C2=A0 =C3=89tienne Mollier <[email protected]>
: :' :=C2=A0 pgp: 8f91 b227 c7d6 f2b1 948c=C2=A0 8236 793c f67e 8f0d 11da
`. `'=C2=A0 sent from /dev/pts/0, please excuse my verbosity
=C2=A0 `-
=20
------=_Part_165680_1611597277.1771498102334
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<html><head></head><body><div class=3D"ydpd9ba3ef1yahoo-style-wrap" style=
=3D"font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px=
;"><div></div>
<div dir=3D"ltr" data-setdir=3D"false">Hi ,</div><div dir=3D"ltr" d=
ata-setdir=3D"false"><br></div><div dir=3D"ltr" data-setdir=3D"false">Thank=
s for the review and the helpful feedback.</div><div dir=3D"ltr" data-setdi=
r=3D"false"><div>
<p data-start=3D"171" data-end=3D"374">I have fixed the autopkgtest PID han=
dling and removed Priority optional and Rules Requires Root from d/co=
ntrol as suggested. The updated changes are pushed to Salsa. Please re revi=
ew the changes.</p>
<div data-start=3D"376" data-end=3D"509">One quick question, since this is =
a packaging only change, should I add a changelog entry using dch or leave =
the changelog unchanged.</div><div data-start=3D"376" data-end=3D"509"><br>=
</div><div data-start=3D"376" data-end=3D"509" dir=3D"ltr" data-setdir=3D"f=
alse"><div>Thanks for the guidance,<br data-start=3D"178" data-end=3D"181">
Harish</div><br></div><div data-start=3D"376" data-end=3D"509"><br></div></=
div><br></div><div><br></div>
=20
</div><div id=3D"yahoo_quoted_1865036856" class=3D"yahoo_quoted">
<div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s=
ans-serif;font-size:13px;">
=20
<div>
On Saturday, 14 February 2026 at 12:17:06 am IST, =C3=
=89tienne Mollier <[email protected]> wrote:
</div>
<div><br></div>
<div><br></div>
<div>hi harish,<br><br>> I have added autopkgtest covera=
ge for the dicomscope package<br>> and pushed the work to Salsa[0]. The =
earlier test issue and<br>> warning are resolved. Kindly review it =
and let me know if any<br>> adjustments are needed.<br><br>> [0] :htt=
ps://salsa.debian.org/med-team/dicomscope/-/tree/master/debian/tests?ref_ty=
pe=3Dheads <br><br>Thanks for your investigations in getting better au=
topkgtest<br>coverage for Debian Med packages! I looked up your chang=
es,<br>plus your question from the Matrix channel:<br><br>>> Should I=
ignore this type of warning that occurs while<br>>> testing packages=
,even after the tests pass?<br>>> tmp/autopkgtest.Hb1m12/build.YWw/r=
eal-tree/debian/tests/run-unit-test: line 25: kill: (95245) - No such proce=
ss<br><br>I see the test is derived from similar autopkgtests relying on<br=
>starting graphical applications within an Xvfb X server, like<br>can be se=
en in edfbrowser[1]. To me, the intent of such test is<br>to make sur=
e that the graphical application is capable of idling<br>without immediate =
crash. Therefore, having lost the process<br>before the kill command =
is invoked may be symptomatic of the<br>graphical application having crashe=
d early and should be<br>investigated. That said, the evaluation of $=
program_pids does<br>capture a pid (95245), which means there is something =
running<br>few milliseconds earlier, or the pid is improperly captured.<br>=
<br>[1]: <a href=3D"https://salsa.debian.org/med-team/edfbrowser/-/raw/mast=
er/debian/tests/run-unit-test?ref_type=3Dheads" target=3D"_blank">https://s=
alsa.debian.org/med-team/edfbrowser/-/raw/master/debian/tests/run-unit-test=
?ref_type=3Dheads</a><br><br>I have run the autopkgtest with a full `ps aux=
` output and a<br>`set -x` invocation, resulting in an output like:<br><br>=
+ ps aux<br> USER =
PID %CPU %MEM VSZ RSS TTY S=
TAT START TIME COMMAND<br> [=E2=80=A6]<br> &n=
bsp; unshare 20 0.0 0.0 4592&=
nbsp; 3368 ? S 18:28 0:00 /b=
in/bash /tmp/autopkgtest.fKYQHc/build.iHv/src/debian/tests/run-unit-test<br=
> unshare 21 0.0 0.0&nbs=
p; 2688 1884 ? S 18:28 =
0:00 /bin/sh /usr/bin/xvfb-run --auto-servernum /usr/bin/dicomscope /usr/=
share/dicomscope/reports/reportsi.dcm<br> unshare &=
nbsp; 32 0.2 0.0 28708 22076 ?  =
; S 18:28 0:00 Xvfb :99 -screen 0 1280x1024x24 -=
nolisten tcp -auth /tmp/xvfb-run.tbuoOC/Xauthority<br> un=
share 35 10.7 0.0 21074700 120684 ? =
Sl 18:28 0:03 java -Xms128M -Xmx16384m -jar /usr/share/java=
/DICOMscope.jar /usr/share/dicomscope/reports/reportsi.dcm<br> &=
nbsp; unshare 79 0.0 0.0 6792 =
3976 ? R 18:29 0:00 ps aux<=
br> ++ ps aux<br> ++ awk '/^unshare.*di=
comscope/ {print $2}'<br> ++ xargs<br> =
+ local 'program_pids=3D21 35 82'<br> ++ awk '-vORS=3D ' =
'/^unshare.*[X]vfb/ {print $2}'<br> ++ ps aux<br> &n=
bsp; ++ xargs<br> + local xvfb_pids=3D32<br> &=
nbsp; + '[' -n '21 35 82' ']'<br> + kill 21 35 82<b=
r> /tmp/autopkgtest.fKYQHc/build.iHv/src/debian/tests/run=
-unit-test: line 27: kill: (82) - No such process<br><br>My impression is t=
hat the $program_pids captures too many pids<br>and you probably want to ma=
ke the awk invocation in the pipeline<br>to capture more precisely the java=
DICOMscope.jar invocation.<br>$xvfb_pids does not have this problem. =
Maybe something like<br>that will do?<br><br> &nb=
sp; local program_pids=3D"$(<br> &nb=
sp; ps aux \<br> | awk "/^$US=
ER"'.* java .*DICOMscope.jar/ {print $2}' \<br> &n=
bsp; | xargs<br> )"<br><br>Al=
so, please avoir `|| true` after the tests, as this would<br>prevent catchi=
ng real issues if dicomscope were to actually<br>crash during autopkgtest.&=
nbsp; Instead, you may like to implement a<br>meanigful error message like =
you may see on edfbrowser's<br>autopkgtest. This will facilitate the =
reading and diagnostic of<br>future autopkgtest failures by just looking at=
the log, instead<br>of having to investigate things by hand from the groun=
d up.<br><br>Other than that, you may like to drop Priority: optional and<b=
r>Rules-Requires-Root: no, as they are now default properties.<br><br>Pleas=
e adjust dicomscope accordingly and ping back when you're<br>done, so someo=
ne can review your changes.<br><br>Have a nice day, :)<br>-- <br>&nbs=
p; .''`. =C3=89tienne Mollier <<a ymailto=3D"mailto:emollier@debia=
n.org" href=3D"mailto:[email protected]">[email protected]</a>><br> =
: :' : pgp: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da<b=
r> `. `' sent from /dev/pts/0, please excuse my verbosity<br> =
`-<br></div>
</div>
</div></body></html>
------=_Part_165680_1611597277.1771498102334--