Bug#1062001: RFS: trader/7.21-1 [RC] -- simple game of interstellar trading

John Zaitseff <[email protected]>
Newsgroups gmane.linux.debian.devel.mentors
Message-ID <aich8vuaytCLBi9b__37783.2286454336$1780949633$gmane$org@zap.org.au>
Hello, Hugh (and others),

> I saw your request on the debian-au mailing list.

Thank you for your reply -- much appreciated!

> Looking at your changelog, I wondered about: "Adjusted build
> dependencies as required for Debian old-stable."  We are uploading
> to unstable/Sid, so your version constraints aren't necessary.

I think I was basing this on Tobias Frost's comment at [1] where he
stated "Please remove all versions from the versioned build depends
that are fulfiled already since oldstable, e.g gettext and
automake."

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1062001#28

I guess I interpreted that to mean all dependencies had to be valid
for Debian old-stable.

I've adjusted the build dependencies to be valid for Debian Sid
(coincidentally also Trixie).  This also includes removing "(>=
2.71)" from autoconf.

> In saying that, I compared your d/control files between trader
> versions.  gettext 0.22 isn't available in oldstable/Bookworm
> anyway.

True, but I also have a backport that can be used for Bookworm (and
also Ubuntu Noble 24.04), in which I apply a patch to allow Gettext
0.21:

  git clone https://git.zap.org.au/git/debian-packages/pkg-trader.git \
    -b master-backports

But this is not relevant for the package I'm trying to get into Sid...

> A copyright check identified some minor discrepancies with the
> copyright years for the following files, compared to what you have
> listed in d/copyright.
>
>  lib/crc-generate-table.c
>  lib/crc-sliceby8.h
>  lib/crc.c
>  lib/crc.h
>  lib/wcsdup-impl.h
>  lib/wcsdup.c
>  lib/wctob.c

Good catch!  I accidentally overlooked the changed end date (2026)
when I updated d/copyright.  Fixed.

>  po/eo.*
>  po/fi.*
>  po/fr.*
>  po/sr.*

I consolidated the range of years per suggestions from the Copyright
field in [2], but made a typo: 2013 should have been 2012.  Fixed --
thanks!

[2] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#copyright-field

> Let me know when you've had a chance to update d/copyright and
> uploaded.  I'll then run dpkg-buildpackage, sign and upload for
> you.

Done.  You can get the updated dsc file by running:

  dget -x https://ftp.zap.org.au/pub/trader/unix/binary/debian/trader_7.21-1.dsc

(Same URL as before, but updated with the changes listed above).
Also available by running:

  git clone https://git.zap.org.au/git/trader.git -b with-debian

Thank you once again!

Yours truly,

John Zaitseff
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.