Bug#1141175: RFS: moraine/0.1.1-1 [ITP] -- snapshot backup over SSH/rsync and rclone
Simon Quigley <[email protected]> Wed, 22 Jul 2026 06:39:09 -0500
| Newsgroups | gmane.linux.debian.devel.mentors |
|---|---|
| Message-ID | <5B303034-5BE9-42FC-8BA9-801C44F8527B__37589.9813416012$1784720491$gmane$org@tsimonq2.net> |
------5IY39VXYQOCSSD6DJCWPCTACB2PMP2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Thanks for the update here=2E It seems like you've addressed most of or al= l of the points=2E Could you please remove the moreinfo tag once a new version is on Mentors? Thanks, Simon On July 17, 2026 3:58:09 PM CDT, Thern AI Solutions <info@thern=2Eio> wrot= e: >Hello Simon, and thanx for contacting me=2E First of all, sorry for the l= ate reply=2E 3 kids, 2 jobs (1 wich is my own business) and a hours takes a= lot of time, and Moraine is something I enjoy working on whenever I get a f= ew hours for myself=2E > >Thank you so much for taking the time to go through this in such detail= =2E I'm still fairly new to Debian packaging and learning something new wit= h every round of feedback, so this is genuinely a big help to me=2E I've ad= dressed all five points: > >1=2E Changelog >=C2=A0 =C2=A0Collapsed it down to a single initial entry and corrected th= e version to 0=2E2=2E0-1 =E2=80=94 I hadn't realised a first upload should = just be one "Initial release" entry rather than carrying the whole history= =2E > >2=2E Copyright / license name >=C2=A0 =C2=A0Renamed the license from "MIT" to "Expat" in debian/copyrigh= t=2E Good learn that Expat is the correct name for this exact license text = in Debian=2E > >3=2E Standards-Version and control fields >=C2=A0 =C2=A0Bumped Standards-Version to 4=2E7=2E4 and dropped both Rules= -Requires-Root: no and Priority: optional from the source stanza=2E > >4=2E debhelper compat >=C2=A0 =C2=A0Upgraded to debhelper-compat 14=2E > >5=2E Watch file >=C2=A0 =C2=A0Upgraded to version 5=2E I learned along the way that v5 is = a new deb822-style format rather than just a version-number bump, so I rewr= ote it with the Version/Source/Mode/Matching-Pattern fields (still tracking= the git tags)=2E > >All five are done in the packaging=2E I'll give it a final lintian run in= a clean unstable chroot and upload the corrected 0=2E2=2E0-1 to mentors=2E= Please let me know if there's anything else I should fix =E2=80=94 I reall= y appreciate the guidance=2E > >Thanks again, >Jonaz > >On 7/14/26 23:18, Simon Quigley wrote: >> Control: tags -1 +moreinfo >>=20 >> Hello, >>=20 >> Thank you for your work here=2E A few things: >> - Please only keep one changelog entry, the initial one, with a correct= ed version=2E The additional changelog entries are not needed=2E >> - In the license file, it is expected to use the license name "Expat" i= nstead of "MIT," please fix that=2E >> - Please update Standards-Version to 4=2E7=2E4, dropping Rules-Requires= -Root: no and Priority: optional=2E >> - Please consider upgrading to debhelper-compat 14=2E >> - Please upgrade the watch file to version 5=2E >>=20 >> I also can't get it to build, see the attached log=2E >>=20 >> If this is a Rust package, you might want to include it in the debcargo= -conf monorepo following their docs: https://rust-team=2Epages=2Edebian=2En= et/book/ >>=20 >> Please remove the moreinfo tag once you're ready for another review=2E = Feel free to CC me, if I'm available I can re-review=2E >>=20 >> Best regards, >> Simon Quigley >> tsimonq2@debian=2Eorg ------5IY39VXYQOCSSD6DJCWPCTACB2PMP2 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head></head><body><div dir=3D"auto">Hello,<br><br>Thanks for the upd= ate here=2E It seems like you've addressed most of or all of the points=2E<= br><br>Could you please remove the moreinfo tag once a new version is on Me= ntors?<br><br>Thanks,<br>Simon</div><br><br><div class=3D"gmail_quote"><div= dir=3D"auto">On July 17, 2026 3:58:09 PM CDT, Thern AI Solutions <info@= thern=2Eio> wrote:</div><blockquote class=3D"gmail_quote" style=3D"margi= n: 0pt 0pt 0pt 0=2E8ex; border-left: 1px solid rgb(204, 204, 204); padding-= left: 1ex;"> <pre class=3D"net-thunderbird-android__plain-text-message-pre"><div dir=3D= "auto">Hello Simon, and thanx for contacting me=2E First of all, sorry for = the late reply=2E 3 kids, 2 jobs (1 wich is my own business) and a hours ta= kes alot of time, and Moraine is something I enjoy working on whenever I ge= t a few hours for myself=2E<br><br>Thank you so much for taking the time to= go through this in such detail=2E I'm still fairly new to Debian packaging= and learning something new with every round of feedback, so this is genuin= ely a big help to me=2E I've addressed all five points:<br><br>1=2E Changel= og<br> Collapsed it down to a single initial entry and correcte= d the version to 0=2E2=2E0-1 =E2=80=94 I hadn't realised a first upload sho= uld just be one "Initial release" entry rather than carrying the whole hist= ory=2E<br><br>2=2E Copyright / license name<br> Renamed the lic= ense from "MIT" to "Expat" in debian/copyright=2E Good learn that Expat is = the correct name for this exact license text in Debian=2E<br><br>3=2E Stand= ards-Version and control fields<br> Bumped Standards-Version to= 4=2E7=2E4 and dropped both Rules-Requires-Root: no and Priority: optional = from the source stanza=2E<br><br>4=2E debhelper compat<br> Upgr= aded to debhelper-compat 14=2E<br><br>5=2E Watch file<br> Upgra= ded to version 5=2E I learned along the way that v5 is a new deb822-style f= ormat rather than just a version-number bump, so I rewrote it with the Vers= ion/Source/Mode/Matching-Pattern fields (still tracking the git tags)=2E<br= ><br>All five are done in the packaging=2E I'll give it a final lintian run= in a clean unstable chroot and upload the corrected 0=2E2=2E0-1 to mentors= =2E Please let me know if there's anything else I should fix =E2=80=94 I re= ally appreciate the guidance=2E<br><br>Thanks again,<br>Jonaz<br><br>On 7/1= 4/26 23:18, Simon Quigley wrote:<br></div><blockquote class=3D"gmail_quote"= style=3D"margin-bottom: 1ex; --net-thunderbird-android__blockquote-default= -border-color: #729fcf;"><div dir=3D"auto">Control: tags -1 +moreinfo<br><b= r>Hello,<br><br>Thank you for your work here=2E A few things:<br>- Please o= nly keep one changelog entry, the initial one, with a corrected version=2E = The additional changelog entries are not needed=2E<br>- In the license file= , it is expected to use the license name "Expat" instead of "MIT," please f= ix that=2E<br>- Please update Standards-Version to 4=2E7=2E4, dropping Rule= s-Requires-Root: no and Priority: optional=2E<br>- Please consider upgradin= g to debhelper-compat 14=2E<br>- Please upgrade the watch file to version 5= =2E<br><br>I also can't get it to build, see the attached log=2E<br><br>If = this is a Rust package, you might want to include it in the debcargo-conf m= onorepo following their docs: <a href=3D"https://rust-team=2Epages=2Edebian= =2Enet/book/">https://rust-team=2Epages=2Edebian=2Enet/book/</a><br><br>Ple= ase remove the moreinfo tag once you're ready for another review=2E Feel fr= ee to CC me, if I'm available I can re-review=2E<br><br>Best regards,<br>Si= mon Quigley<br>tsimonq2@debian=2Eorg<br></div></blockquote></pre></blockquo= te></div></body></html> ------5IY39VXYQOCSSD6DJCWPCTACB2PMP2--