Re: Help with packaging - cunit

Hi,

On Tue, Aug 11, 2026 at 12:36:03PM +0200, Edmund Lodewijks wrote:
>  1. `.gitignore` is not part of upstream, it's purely for salsa. `dpkg
>  source` ignores `.gitignore` from every source package it builds, so
>  this should be fine.

What did the reviewer complain about regarding the .gitignore? What does 
Lintian say?

>  2. -dfsg → +dfsg
>  While I agree that the + format is more modern, I don't think I can
>  change it now. the - format has been used since 2006. I ran `dpkg --
>  compare-versions "2.1-3+dfsg-3" gt "2.1-3-dfsg-2.7" ; echo $?` which
>  returns `1` (meaning: false, the + format is not seen as greater-than
>  the - format). So, I don't think a change would work at all; it would
>  mess up the package version ordering in Debian.

You're right. Since the upstream version is 2.1-3 (which is unusual), 
you need to wait for upstream to do a release with a highr number than 
that to be able to change from -dfsg to +dfsg. Just don't forget to do 
that (should that upstream ever release again)

>  3. Version churn (the dsfg-3,4,5,6,...)
>  Yes, I agree, it's ugly. This is the first Debian package I am intend
>  to adopt. I thought I had it all sorted in the first upload, but you
>  came with good suggestions for changes and I learned a few things. As
>  a result, more uploads. I am worried the lintian (on mentors) or
>  uploads won't work if I keep the same version number. If needed, I can
>  always squash these changes (also in the changelog) before it's handed
>  over to the Debian uploader?

Unless you have uploaded to debian proper, you're generally free to edit 
changelog at if you keep the version numbers in order. The exception is 
when people have installed one of your intermediate versions and you 
want them to be able to upgrade automatically. If you prepare the 
Denbian upload, just make sure that the changelog contains all entries 
you want to be there.

>I would be very grateful if someone could have a look at this package 
>and see if it fits the bill, or if I should make more changes before 
>it can be uploaded.
>
>Since I was busy on that package, I have done some more bug wrangling 
>based on the website with RC bugs (they seem the most important?), and 
>gained a little more experience. I think that I could (but not sure if 
>I should!) "hide" some of the lintian warnings via a 
>`lintian-overrides` file. For those things that I cannot change (e.g. 
>hyphen-in-upstream-part, or deprecated-configure-filename), should I 
>create a lintian-override? Or, for the latter, a patch to rename the 
>file?

I'd do a lintian override. If you put a # comment in front of the 
override line, lintian will show that in its reports so that people can 
see your explanation.

Greetings
Marc