Bug#1121498: libreoffice: Preprocessor macros in pdfium confuse arm64 with sparc64

Hi,

Am 27.11.25 um 18:59 schrieb Rene Engelhard:
> BTW, is this is not a patch. Not for *libreoffice*.
> 
> 
> It would have been a patch to *libreoffice* if it included external/ etc and is not just the pdfium part which needs to be applied with makefile magic...

It doesn't even apply against the version you report it to:
rene@frodo:~/LibreOffice/git/libreoffice-25-8/tarballs/pdfium$ patch -p1 < ~/0001-core-fxcrt-numerics-Fix-incorrect-preprocessor-check.patch
patching file core/fxcrt/numerics/safe_math_clang_gcc_impl.h
Hunk #1 FAILED at 14.
1 out of 1 hunk FAILED -- saving rejects to file core/fxcrt/numerics/safe_math_clang_gcc_impl.h.rej

#if !defined(__native_client__) && (defined(__ARMEL__) || defined(__arch64__))
#include "core/fxcrt/numerics/safe_math_arm_impl.h"
#define BASE_HAS_ASSEMBLER_SAFE_MATH (1)
#else
#define BASE_HAS_ASSEMBLER_SAFE_MATH (0)
#endif

is the lines there.

Please send patches not to random versions if you report against libreoffice 25.8.3-1, which has pdfium 7012 embedded.

ONLY applies in master/26.2.0 alpha1:

rene@frodo:~/LibreOffice/git/master/tarballs/pdfium$ patch -p1 < ~/0001-core-fxcrt-numerics-Fix-incorrect-preprocessor-check.patch
patching file core/fxcrt/numerics/safe_math_clang_gcc_impl.h

Regards,

Rene

> 
> 
> Regards,
> 
> 
> Rene
>