Re: Bug#1121530: libreoffice: Please build with -fPIE on sparc64 to fix FTBFS

Hi Rene,

On Sat, 2025-11-29 at 09:20 +0100, Rene Engelhard wrote:
> Am 28.11.25 12:02, schrieb John Paul Adrian Glaubitz:
> > 
> > The attached patch replaces "-fpic" with "-fPIC" in the lp-solve build script which
> > seems to be enough to fix this particular build issue on sparc64.
> 
> Can you please do some care in your "patches" so that one doesn't need to
> replicate anything in them which makes the patch moot in the first place?

I'm not familiar with the libreoffice as you are, so that patch was just a suggestion.

> Here even a new patch patching ccc is not needed at all. In this case
> external/lpsolve/lp_solve_5.5.patch already adds
> +     pic=-fpic
> itself. Which is used.
> 
> So the correct patch is
> --- external/lpsolve/lp_solve_5.5.patch-old	2025-11-28 19:18:23.702374716 +0100
> +++ external/lpsolve/lp_solve_5.5.patch	2025-11-28 19:18:33.730426860 +0100
> @@ -28,7 +28,7 @@
>  +     a=a
>  +     soprefix=lib
>  +     libs="-lm"
> -+     pic=-fpic
> ++     pic=-fPIC
>  +     ldflags="-Wl,-Bsymbolic -Wl,-soname,liblpsolve55.$so"
>   fi

That's great! Hope you can make this change as suggested. Once a new version of the
libreoffice package has been uploaded, I'll look into debugging possible testsuite
failures on sparc64.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913