Bug#1121498: libreoffice: Preprocessor macros in pdfium confuse arm64 with sparc64

John Paul Adrian Glaubitz <[email protected]>
Newsgroups gmane.linux.debian.devel.openoffice
Message-ID <db2353c789728194f413bf40dc12e4dee231e737.camel__47474.9917326093$1764695549$gmane$org@physik.fu-berlin.de>
Hi,

On Tue, 2025-12-02 at 18:08 +0100, Rene Engelhard wrote:
> > On Tue, 2025-12-02 at 18:03 +0100, Rene Engelhard wrote:
> > > Am 02.12.25 um 17:58 schrieb John Paul Adrian Glaubitz:
> > > > 14:43 <ricotz> (__arch64__) sollte wohl entfernt werden -https://pdfium.googlesource.com/pdfium/+/refs/heads/main/core/fxcrt/numerics/safe_conversions.h
> > > > OK, I'll drop __arch64__ altogether then. I'm still struggling to fix my Gerrit access
> > > > in the mean time to fix this issue upstream in pdfium.
> > > If I understand that one right this *is* like this upstream in master already. That link is to
> > > 
> > > https://pdfium.googlesource.com/pdfium/+/refs/heads/main
> > What do you mean? The wrong check for the __arch64__ macro is still there, see:
> > 
> > https://pdfium.googlesource.com/pdfium/+/refs/heads/main/core/fxcrt/numerics/safe_math_clang_gcc_impl.h#17
> 
> Ah, right, he mentioned the gcc one where this is the clang one (which is used).
> 
> 
> Will remove in the patch anyways.

Yeah, just drop the __arch64__ then, please.

I will take care of landing this fix upstream and also the arch definitions for the
other architectures to enable the pdfium build there out of the box.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.