Re: Please help reviewing mon-client

On 2/11/25 10:08, Andreas Tille wrote:
> Hi,
> 
> mon-client was a candidate for the bug of the day today and thus I had a
> look.  The autopkgtest never succeeded due to Perl syntax errors and I'm
> actually wondering how that code could have been used at all.  I tried
> my best (which is admittedly very less) but the autopkgtest keeps on
> failing as you can see in Salsa CI[1].
> 
> If your time permits having a look I'd be very happy.
> 
> Kind regards
>     Andreas.
> 
> [1] https://salsa.debian.org/debian/mon-client/-/jobs/7071136

Hi,

the problem comes from Mon/Config.pm:

$ perl -cw Mon/Config.pm
Global symbol "%groups" requires explicit package name (did you forget 
to declare "my %groups"?) at Mon/Config.pm line 363.
Global symbol "$STAT_UNTESTED" requires explicit package name (did you 
forget to declare "my $STAT_UNTESTED"?) at Mon/Config.pm line 499.
Global symbol "$STAT_UNTESTED" requires explicit package name (did you 
forget to declare "my $STAT_UNTESTED"?) at Mon/Config.pm line 500.
Mon/Config.pm had compilation errors


This file is using a %groups variable which isn't declared anywhere and 
this file has "use strict" which forbid this.

Note that this looks like a real bug, this variable is never initialized 
anywhere so will stay empty.

Best regards,
Xavier