Bug#1113874: RFH: [Re: Bug#1113874: Please upload new version of perl-tk]

Control: found -1 1:804.036+dfsg1-7 
Control: tag -1 patch

(dropped debian-devel@ but added debian-perl@ instead)

On Fri, Aug 07, 2026 at 12:06:21PM +0200, Georges Khaznadar wrote:
> Hi Dominique, hi debian-devel@,
> 
> I tried to fix perl-tk, because Bug#1113874, with no success so far.

Hi, this bug was closed with the 1:804.036+dfsg1-7 upload, but the bug is
unfortunately still present, as seen with this:

  # perl -we 'use Tk::Pane'
  Possible precedence problem between ! and numeric eq (==) at /usr/lib/x86_64-linux-gnu/perl5/5.42/Tk/Pane.pm line 302.

So reopening.

> The upstream repository, https://github.com/eserte/perl-tk/ shows no
> change since half a year; I raised an issue about it at
> https://github.com/eserte/perl-tk/issues/123
> 
> Unfortunately, updating the source package to its current head from github
> does not fix the issue.

To the contrary, my tests indicate that the attached patch from

  https://github.com/eserte/perl-tk/commit/3a13aed7a07cd82347695b9595234f629803aef3

fixes the issue. Please use this instead of the current ineffective patch.

> Last but no least: I have very poor skills about Perl and its test framework.
> Thank you in advance for any help or suggestion.

Have you considered moving perl-tk to the pkg-perl group maintenance?
I think it would fit there well. See https://perl-team.pages.debian.net/
for more information.

Hope this helps. Thank you for maintaining perl-tk.
-- 
Niko

From 3a13aed7a07cd82347695b9595234f629803aef3 Mon Sep 17 00:00:00 2001
From: Slaven Rezic <[email protected]>
Date: Sat, 5 Apr 2025 20:58:59 +0200
Subject: [PATCH] Tk::Pane: fix precedence warning (new in perl 5.41.x)

Warning looked like this:

   Possible precedence problem between ! and numeric eq (==) at .../blib/lib/Tk/Pane.pm line 297
---
 Tk/Pane.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Tk/Pane.pm b/Tk/Pane.pm
index fa63b1a6..84c783c1 100644
--- a/Tk/Pane.pm
+++ b/Tk/Pane.pm
@@ -294,7 +294,7 @@ sub xyview {
 
 	my $gridded = $pan->{Configure}{'-gridded'} || '';
 	my $do_gridded = ($gridded eq 'both'
-				|| (!$horz == ($gridded ne 'x'))) ? 1 : 0;
+				|| ((!$horz) == ($gridded ne 'x'))) ? 1 : 0;
 
 	if($do_gridded && $mul eq 'pages') {
 	    my $ch = ($slv->children)[0];

Origin: backport, https://github.com/eserte/perl-tk/commit/3a13aed7a07cd82347695b9595234f629803aef3
Bug-Debian: https://bugs.debian.org/1113874