patch para pbuilder

Herbert Parentes Fortes Neto <[email protected]>
Newsgroups gmane.linux.debian.devel.portuguese
Message-ID <[email protected]>
Olá,

estou seguindo as orientações do how-can-i-help.

peguei um bug 'tagged as gift'   do pacote pbuilder-0.215
+nmu3(testing)[0].

Rodei o shellcheck no arquivo pbuilder-apt-config. Tirei os alertas mais
fáceis e fiz um patch com o '$ diff -u pbuilder-apt-config.orig
pbuilder-apt-config > pbuilder-apt-config.patch'. Arquivo anexo para
quem quiser verificar.

Tá tudo certo? Eu teria que agora reportar o patch? Como faria isso?
Ainda tem dois alertas. Que para mim demorariam de serem verificados.

In pbuilder-apt-config line 105:
              \#*|""|*)
              ^-- SC1001: This \# will be a regular '#' in this context.

In pbuilder-apt-config line 457:
command="$1"
^-- SC2034: command appears unused. Verify it or export it.


abraços
hpfn


[0] - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753966
pbuilder-apt-config.patch (text/x-patch, 4.1 KB)
--- pbuilder-apt-config.orig	2014-09-29 11:42:45.107565348 -0300
+++ pbuilder-apt-config	2014-09-29 11:48:50.759553686 -0300
@@ -225,12 +225,12 @@
     esac
 }
 
-getopt_output="`getopt -o "" -l help,with-sources::,arch:,components:,archive:,mirror:,mirror-map:,suite:,pockets:,profile: -n "$self" -s sh -- "$@"`"
+getopt_output="$(getopt -o "" -l help,with-sources::,arch:,components:,archive:,mirror:,mirror-map:,suite:,pockets:,profile: -n "$self" -s sh -- "$@")"
 
 eval set -- "$getopt_output"
 
 with_sources="disabled"
-arch="`dpkg --print-architecture`"
+arch="$(dpkg --print-architecture)"
 components="main"
 archive=""
 mirror=""
@@ -324,8 +324,8 @@
 if [ -n "$profile" ]; then
     base_dist="${profile%%/*}"
     base_dist="${base_dist%%-*}"
-    base_archive="`guess_dist_arch_archive "$base_dist" "$arch"`"
-    base_mirror="`get_archive_url "$mirror_map" "$base_archive"`"
+    base_archive="$(guess_dist_arch_archive "$base_dist" "$arch")"
+    base_mirror="$(get_archive_url "$mirror_map" "$base_archive")"
     case "$base_archive" in
       debian|debian-archive)
         case "$profile" in
@@ -336,7 +336,7 @@
           ;;
           *-proposed-updates/volatile)
             archive="debian-volatile"
-            mirror="`get_archive_url "$mirror_map" "$archive"`"
+	    mirror="$(get_archive_url "$mirror_map" "$archive")"
             volatile_dist="$base_dist/volatile"
             add_output_sources "$with_sources" "$base_mirror" "$base_dist" "$components"
             add_output_sources "$with_sources" "$mirror" "$volatile_dist" "$components"
@@ -347,7 +347,7 @@
                 die "Unknown Debian Volatile based profile=$profile"
             fi
             archive="debian-volatile"
-            mirror="`get_archive_url "$mirror_map" "$archive"`"
+	    mirror="$(get_archive_url "$mirror_map" "$archive")"
             volatile_dist=${profile%-sloppy}
             add_output_sources "$with_sources" "$base_mirror" "$base_dist" "$components"
             add_output_sources "$with_sources" "$mirror" "$volatile_dist" "$components"
@@ -360,7 +360,7 @@
                 die "Unknown Backports.org based profile=$profile"
             fi
             archive="backports.org"
-            mirror="`get_archive_url "$mirror_map" "$archive"`"
+	    mirror="$(get_archive_url "$mirror_map" "$archive")"
             add_output_sources "$with_sources" "$base_mirror" "$base_dist" "$components"
             add_output_sources "$with_sources" "$mirror" "$profile" "$components"
           ;;
@@ -369,7 +369,7 @@
                 die "Unknown Debian Security based profile=$profile"
             fi
             archive="debian-security"
-            mirror="`get_archive_url "$mirror_map" "$archive"`"
+	    mirror="$(get_archive_url "$mirror_map" "$archive")"
             add_output_sources "$with_sources" "$base_mirror" "$base_dist" "$components"
             add_output_sources "$with_sources" "$mirror" "$profile" "$components"
           ;;
@@ -421,7 +421,7 @@
         done
         if [ "$has_security" = "yes" ]; then
             archive="ubuntu-security"
-            mirror="`get_archive_url "$mirror_map" "$archive"`"
+	    mirror="$(get_archive_url "$mirror_map" "$archive")"
             if [ "$mirror" != "$base_mirror" ]; then
                 add_output_sources "$with_sources" "$mirror" "$base_dist-security" "$components"
             fi
@@ -438,9 +438,9 @@
 if [ -n "$suite" ]; then
     if [ -z "$mirror" ]; then
         if [ -z "$archive" ]; then
-            archive="`guess_dist_arch_archive "$suite" "$arch"`"
+		archive="$(guess_dist_arch_archive "$suite" "$arch")"
         fi
-        mirror="`get_archive_url "$mirror_map" "$archive"`"
+	mirror="$(get_archive_url "$mirror_map" "$archive")"
     fi
     add_output_sources "$with_sources" "$mirror" "$suite" "$components"
     for pocket in $pockets; do
@@ -448,7 +448,7 @@
     done
     # NB: archive might be empty; best effort to try to guess it
     if [ -z "$archive" ]; then
-        archive="`guess_dist_arch_archive "$suite" "$arch"`" 2>/dev/null || true
+	    archive="$(guess_dist_arch_archive "$suite" "$arch")" 2>/dev/null || true
     fi
     set_debootstrap_suite "$archive" "$suite"
     debootstrap_mirror="$mirror"
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.