Re: RFS: aterm/1.0.1-9 - QA: Afterstep XVT - a VT102 emulator for the X window system

Antonio Terceiro <[email protected]> Wed, 9 Mar 2016 08:07:05 +0700
Newsgroups	gmane.linux.debian.devel.portuguese
Message-ID	<[email protected]>
Oi Marcio,

On Tue, Mar 08, 2016 at 12:11:10AM -0300, [email protected] wrote:
> Prezados,
> 
> Estou procurando um sponsor para o pacote aterm, é um trabalho de QA.
> 
>  * Nome do pacote     : aterm
>  * Versão             : 1.0.1-9
>  * Upstream Author    : Sasha Vasko <[email protected]>
>  * URL                : ftp://ftp.afterstep.org/apps/aterm/
>  * License            : GPL-2
>    Section            : x11
> 
> Produz os seguintes binários:
> 
> aterm      - Afterstep XVT - a VT102 emulator for the X window system
> aterm-ml   - aterm for Japanese, Chinese, Greek and Thai
> 
> Para acessar o pacote:
> http://mentors.debian.net/package/aterm
> http://mentors.debian.net/debian/pool/main/a/aterm/aterm_1.0.1-9.dsc

a maior parte das mudanças que você fez parecem boas.  seguem comentários
inline nas partes relevantes do diff entre o seu pacote e a versão que está
atualmente no unstable.

> --- aterm-1.0.1/debian/changelog	2012-03-29 02:11:44.000000000 +0700
> +++ aterm-1.0.1/debian/changelog	2016-03-06 05:48:34.000000000 +0700
> @@ -1,3 +1,33 @@
> +aterm (1.0.1-9) unstable; urgency=medium
> +
> +  * QA upload.
> +  * Bumped Standards-Version to 3.9.7.
> +  * Created file d/clean.
> +  * Inserted "set -e" in files d/*.prerm and d/*.postinst.
> +  * Removed the files d/*.override.
> +  * Removed the files d/*.install.
> +  * Updated the files d/*.links.
> +  * Updated the file d/aterm-ml.manpages.
> +  * debian/control:
> +    - updated short description the aterm-ml.
> +    - removed suidmanager the Conflicts field.
> +  * debian/copyright:
> +    - update to format standard machine-readable.
> +    - updated file.
> +  * debian/rules:
> +    - updated to small format.
> +    - updated to enables hardening options.
> +    - updated to enable LFS support.
> +    - compiled a single version of aterm with support for
> +    Japanese, Chinese, Greek and Thai characters.
> +  * debian/patches:
> +    - created patch fix_spelling.
> +  * debian/watch:
> +    - upgrade to format 4.
> +    - updated file.
> +
> + -- Marcio de Souza Oliveira <[email protected]>  Sat, 05 Mar 2016 22:21:46 -0200

vários dos itens acima me dizem *o quê* você fez, mas não *porquê* você os fez.
tente se colocar no lugar de alguém que vai ler o changelog sem olhar o diff.
por exemplo, após olhar o diff _eu acho_ que o fato de que você removou
debian/*.install está relacionado às mudanças no debian/rules, mas isso não
está claro.

outro exemplo: "Created file d/clean" não diz nada além do que eu é óbvio, que
você criou debian/clean. mas porquê você fez isso?

também não tem porquê abreviar o "debian/", na minha opinião. o changelog vai
ser comprimido de qualquer forma.

> diff -Nru aterm-1.0.1/debian/clean aterm-1.0.1/debian/clean
> --- aterm-1.0.1/debian/clean	1970-01-01 07:00:00.000000000 +0700
> +++ aterm-1.0.1/debian/clean	2015-12-15 05:04:16.000000000 +0700
> @@ -0,0 +1,3 @@
> +src/version.h
> +scripts/random_colors
> +config.log

esses arquivos são criados durante a compilação, é isso? escreve isso no changelog

> diff -Nru aterm-1.0.1/debian/control aterm-1.0.1/debian/control
> --- aterm-1.0.1/debian/control	2012-03-29 02:09:12.000000000 +0700
> +++ aterm-1.0.1/debian/control	2016-03-06 00:34:28.000000000 +0700
> @@ -3,14 +3,13 @@
>  Priority: optional
>  Maintainer: Debian QA Group <[email protected]>
>  Build-Depends: debhelper (>= 9), libx11-dev, libxt-dev, libafterimage-dev (>= 2.2.9), librsvg2-dev, autotools-dev
> -Standards-Version: 3.9.3.1
> +Standards-Version: 3.9.7
>  Homepage: http://aterm.sf.net
>  
>  Package: aterm
>  Architecture: any
>  Depends: ${shlibs:Depends}, ${misc:Depends}
>  Provides: x-terminal-emulator
> -Conflicts: suidmanager (<< 0.50)

por quê? (veja acima)

>  Description: Afterstep XVT - a VT102 emulator for the X window system
>   Aterm is a colour vt102 terminal emulator, based on rxvt 2.4.8 with
>   some additions of fast transparency, intended as an xterm replacement
> @@ -26,8 +25,7 @@
>  Recommends: aterm
>  Suggests: xfonts-intl-european, xfonts-intl-chinese (>= 1.1-4) | xfonts-cmex-big5p
>  Provides: x-terminal-emulator
> -Conflicts: suidmanager (<< 0.50)
> -Description: Afterstep XVT - a VT102 emulator for the X window system
> +Description: aterm for Japanese, Chinese, Greek and Thai

Sugiro o seguinte:

Description: Afterstep XVT - a VT102 emulator (support for Japanese, Chinese, Greek and Thai)

>   Aterm is a colour vt102 terminal emulator, based on rxvt 2.4.8 with
>   some additions of fast transparency, intended as an xterm replacement
>   for users who do not require features such as Tektronix 4014

[...]

todo o resto parece bom. compila ok com sbuild, e o lintian tá quietinho.
signature.asc (application/pgp-signature, 819 B)