Re: review for python-atom/0.11.0-1
Alexander Sulfrian <[email protected]>
| Newsgroups | gmane.linux.debian.devel.python |
|---|---|
| Message-ID | <[email protected]> |
Hi Jeroen, thanks for the quick and detailed review. On 9/29/25 18:17, Jeroen Ploemen wrote: > * diff between orig tarball from uscan and pristine-tar branch > (output from tardiff -m -s): > + PKG-INFO > + atom.egg-info > + atom.egg-info/PKG-INFO > + atom.egg-info/SOURCES.txt > + atom.egg-info/dependency_links.txt > + atom.egg-info/requires.txt > + atom.egg-info/top_level.txt > + atom/version.py > + setup.cfg I do not know how that could happen. Maybe I started the package with the pypi distribution tar. I recreated the repo (and the pristine-tar) branch from the uscan information. > * control: possible missing build-dep on python3-psutil, (optional) > import at tests/test_mem.py:21 Thanks for catching this, dependency added. I added (and forwarded to upstream) a patch to fix a type hint error while building the documentation and added the examples to pybuild.testfiles. Now all tests are run and only one tests is skipped intentionally. > * control: version requirements for the build-deps on > python3-setuptools, python3-setuptools-scm, python3-cppy are > ancient (already met in oldstable), please remove. Removed. > * d/.docs, d/.examples: files could be moved to the documentation pkg? Done. As the examples are already referenced in the generated sphinx documentation, I added jdupes to link the same files. Keeping the examples under /usr/share/doc/python-atom-doc/examples/ might improve the discoverability. > * rules: override of dh_sphinxdoc might ignore nodoc build profile. Fixed. > I assume the initial upload was rejected over missing copyright info? Yes. Once the new upload is sponsored I would reply to the ftpmasters, that the issues in the copyright file are fixed. Thanks, Alex
OpenPGP_0x0BD13B63E2A9AF58.asc
(application/pgp-keys, 3.1 KB)
-----BEGIN PGP PUBLIC KEY BLOCK----- xsFNBGeuNewBEACaCJPunjRmKJ4ODm+GAjAB6US/V/ZqngLerByNOlWY4/f4fomR UjS68qhY47Id7Pr3Wk3vanJhQ3izWgN1qIqpzG650zPEAR8ngySPBT9OxJj8Jfjn zpbwbDS+PpFaKkcByH1LTnIex9Rapmg/h8epPQ/zouZ7nerkJVU8YE5fKKtYRorz Pxm7L5aZ7oMgJ07PEFL2/pAhxt94X6diCr+Ng9AQud+qiBV6ds45YEn1wjoiTTEC UKjo+VbajnmPANZmlEd1JFaMteI/FSJArUs1C1awtv4lebj+n1IKKgU924IOsrwH VbvLWY6LrszzVoHFAALM4OTMYoG0bN6bIXBn16uC81OXPE8QDE1Ei1W+3CgpRQLJ LV9ZJ3f5m3idNUpE49o9SA3v67DYiuhmORFdSnlyeeAbaRlZLF91jww78uObeUBs IoLpcfGrdjF2JJd8oah75DY2NCWwZ97NizLW6P/jUSUI232LmTHBsIYWQJj/EBcE e0k2NmbfREy7LA3an2xwqiwUw9D6/Etkdo9yTvGjBA2nYYVl71hGBds5ZeAfE+qd iOz/+UsLOmUzf0TU/fURlK0suEIGOEiJomy1W2tqaPzGXNdre4scmzMovkE0XeLU nbV89yGL0QO7SltXVOgw3xxsRYGnOaJsH8CJCh/GCmXA7aHuS9m9zKc6BQARAQAB zStBbGV4YW5kZXIgU3VsZnJpYW4gPGFsZXhhbmRlckBzdWxmcmlhbi5uZXQ+wsGU BBMBCgA+FiEE9Gf8oMN/p2xEGE2UC9E7Y+Kpr1gFAmeuNewCGwMFCQlmAYAFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQC9E7Y+Kpr1i01Q//dNVWBCXYgxMpfb1b IeOrbFj1OvWiQVPS6zOhcDg2ParWx72Iwzp943CNOP7S7lZ5seAyIkJ97t6BXm8/ ihBVaOZ9tUVINm0qeVOYsWch5qwTS0qa2y/KFRo/XbzndAijb90RffPA3/9DON7s yOwygzC9QCjuAnqbuoddz4wdhFtu0U2cFdNzF5lHlIIOoZ/FA2ZNEKS6pvGsC7dN lsiyKE2fOF4rZQKxU316YQON1MCnERBd+YpX+mNQcUU7Esq51I7L7qqmBn4yEPIM 9tasfZV9ubbe3ZoVdNXA77qNp5kB1W6Jlx+KFLjNqSZANDOXHypPoXZ0klFbQaSW tkT3zJUjqqOkKmE4CLAaRksWXYwPdBuqpau/xbNz7wBw3YmY1ib0Uqd5WFvi3+tN VOqP4PCMdZ6o3KasFuNp/DJ8z1j0IJXOqzqqRu+63Omhs1GN8qwkMiZHuZPyS6g8 zY3QqzaNA5D15M3CJAT+hBd5uv50/vhvmsWtBJOUxsm3720NXQdkkuzBgzHUxmte JJONtVyTJFLQG/RVxLRw6VieZA6ulPhGZAUEPqWoIlXZJ2GF0aFY7INhYZTqPm0J e6eI7XaqlI6l/cWDmiF7FswpWfWfLUUKqPTPU2+Tlv1gHqLqh6xvFcWOpqSPutXl /Ai53V7ZmGzOmUkJPRgaxRqkMnXOwU0EZ6417AEQANQQ3lF2ABErtOuGDnpAVSE4 AkR8GHE6MqMZu7fRK53rHkTA8MzU9kpF3e1UpZMNIqgJ8Rc9yidxeE7eXzMJGbgG U3X5j2LLgBfEgOWJUgFHZdQHSeOUo0UkJwh5P2pcXNBfxtbzFopmneFtpw1fwdiU 4EjRtX3HzYxXyV0Cx2JZMRjAlz6shQnPfrAPI1cOE6VR3lRG+Ba3tmMvkC9gcgij BDVqZJ7fcm+sGWkAWGs00Oj2rDTPitvPA9ghn6LND/4xdscZxoCH5KFtzTA9Kvic CddkJDjUHZc9NSaPHaQr45mi7h8bNIZyR9EVgN82rLWlid0R4NLuT3xyuycHLL6A D/7agf0WPtTp1q4hF5PzjSJMdFcLroWFbxIwyHB23AmVlKZUAxvsS0RESjDt/NzK riEvGqM1prvB/Ap3h8W8zEjHoLSyHf3HdT2ok6iwVfO9Fl0yI8kmdAZeIgeObdnO 13+uEvISm5QF01PvYRmuUsR4mO+5lbeEIqjYoa3TteNvh60Hk52NlSFBDUd8cE0t zF1CbwGFi7KIwfNQC+kD+nGAoJq5FipYj3bq0slzd/GcwYOInAQpOiXJX/unE+wt 1Fz62DKxqczh3t1ISPRqQMPUaklH0/73OHbOtbalhq+Q1HPXE9Hs6gxybsaRWFBF wijcyjdb3Xdw02i90uSXABEBAAHCwXwEGAEKACYWIQT0Z/ygw3+nbEQYTZQL0Ttj 4qmvWAUCZ6417AIbDAUJCWYBgAAKCRAL0Ttj4qmvWKQeD/97yanOWMyzkeegKMx+ 65UwrpUhFWsaLfvhowcO5LvVtwqj9dlAEnFwz5lrt+uS/QXrqly6NPSADovrdxm2 w2vVEch5wK6yyis+nedhOFISD8vZ3gGlt5YWF/rl0mqxiiCStfUFXn3x5EVAvGHa GCRTWqcmT4FUBvd6XD1WdxBNPse6QFdlfYnUt53eeOI8tQ+wetxlFOBZeXFBD6tk CZM9MRL81h1K6BAm8rL1RR+HVDOTMyyXpmHTHWiBpyM/9lXdfDlvFQB9UcrVgXd4 15Kx7eUSmO9OvJrksnn61lm/cot12mrdsach975x9mDXFFsHd0LOhiWoDiyREveV ZJZi3flxPgzaaFnzO52cutiI8LAyW9Pq7F7w1EHsKXf5asthqar6hGfF+ZinhWKE rzJoHA72INZzgRuvhUJjxISyoUbhi5WN7tlQvO0UQQm/GhNpijNTpUvY78qWdYDi i3pOB5TN/FQncYlcpP2Xw4bGIEh+ux+7GcJUvXVsBaK7cRAwA+j++TFR6wKPoT1A jZMeOcJRA9nnVTeNkx1Ml6wsmln9umocfaLDkNgESBjkb4/L7HGTCYdI8LIf63dQ 4XqI3fhRhoF1srKbpsWXqh1DoPRkYsjKiaYIz/3Luih8Qe5+80z0ivRnhkic7qLP LuJRyiuGbHSKy/BJMk5qsIKc/g== =+PW6 -----END PGP PUBLIC KEY BLOCK-----
OpenPGP_signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE9Gf8oMN/p2xEGE2UC9E7Y+Kpr1gFAmjbkaMACgkQC9E7Y+Kp r1hCMA/+NVP3TeVK9Wv6mwyVJNToN8n9gKmhNdHzWmlI2TqJlOpdnrZeJ2QN0cJC 10CguGH0BSmJ2fk/wNSrJI0WHVq7+ikGSK17oOzMKjvD7LhRCGMG886gm2bOBGwl RHI0J1614eXtBdnuOk+AcANMYSsgEzxydlueg8KpgQNmhwY1y0I07Sj16KiTlWaw fspn/alPqQokonOOlb5+gXyl/9uljdQA4nVRHhvI6UYnOet5BE+Y92nO71MUWTKS FsYa+/gdO9HKKR4HXkUjZJ25RKNckXkqJ2G+TMiK6a+IJFG3YHIqcF3YageZFisI a5YGY612UddVCn9Eypx3AI8sjWxJj9y7pfEogF9NMCfVtYcOO0QTQpTGlPA605dn qEuZLz2g1n/780ywULaGeedwW5oySImv9twO4S1nmBmw9B99lBRsPwoVX2SgjVZk eZpzQ3QQT0czGy3D9xl64xB484Jv/P0kw3L5Qvb0rbPrxTCOnX+DFliBZhCVjgPv Ar7fdqBjV+4Yyffxn2HVgiiCXH/UQp8BBZqMGqIK/+Bz6NhNb1xAhvuTZ5tu5d6a lDDSHSlCP89pPCOZowNanD4e7PlkyVqt/1qcgAqK5LBmB0YH63zhdTeElI0rBmW1 yep9Qis4W4lB4aKDOxnZceYpQp8PPQ9r+8/4c9ak8V+6bOlRWmM= =Ji6s -----END PGP SIGNATURE-----