Re: review for ocrfeeder/0.8.5-2
Pieter Lenaerts <[email protected]>
| Newsgroups | gmane.linux.debian.devel.python |
|---|---|
| Message-ID | <[email protected]> |
Op 8/11/2025 om 18:13 schreef Jeroen Ploemen: > I took a look at the ocrfeeder package, up for sponsorship in the > Python team: > > * copyright: assorted missing entries, including: I've used cme to update d/copyright. It's quite a lot of changes now. > * control: unused dependency on python3-lxml? > * control: old debhelper compat level 12 (current is 13). Done. > * patches: newly added 'remove_gnome_autogen.patch' looks redundant; > recent compat levels run autoreconf by default and the package > seems to build fine without it (the .deb is identical too). The > related override in d/rules can go as well. Done > * watch: regexp (\d\.\d) in the Source line is overly specific, could > easily miss realistic future versions such as 0.10; something like > '\d[\d.]*' avoids that problem while still limiting to digits and > dots only. Done. I also adressed bug #1085746 <https://salsa.debian.org/python-team/packages/ocrfeeder/-/commit/3a322e10d9fe468b83b63c05d22f93789d81b48d> Thanks for your time and pointers! Pieter