Re: python-lsp-server new upstream version

On Sat, 2025-11-22 at 13:39 -0300, Aeliton G. Silva wrote:
> On Sat, 2025-11-22 at 20:35 +0500, Andrey Rakhmatullin wrote:
> > > > > > Can you test if this is a test only dependency and can be
> > > > > > annotated
> > > > > > with <!nocheck>?
> > > > > > 
> > > > > 
> > > > > Good shout, thanks. websockets are in the [project.optional-
> > > > > dependencies] in the pyproject.toml of the upstream, so I
> > > > > assume it
> > > > > should be annotated with <!nocheck>.
> > > > 
> > > > What matters is whether it's used for building or just for
> > > > testing
> > > > and
> > > > whether the package builds fine with the nocheck build profile
> > > > after
> > > > your
> > > > changes. You shouldn't just guess.
> > > 
> > > If I remove either black or python3-websockets from
> > > debian/control,
> > > gbp
> > > buildpackage will succeed creating python_lsp_server-1.13.2-py3-
> > > none-
> > > any.whl, but the test session will fail when any of the packages
> > > is
> > > not
> > > installed.
> > > 
> > > The debian package builds normally after annotating both
> > > dependencies
> > > with <!nocheck>.
> > 
> > Still, it's a bad idea to annotate deps with a build profile
> > without 
> > actually testing it.
> > 
> 
> I think I understood now what testing means here.
> 
> I read [1] which references another resource [2] that says:
> 
> "For this to work it means that failing to build from source with the
> nocheck build profile will have to be RC, but until the bookworm
> release we will accept lower severity. Please consider checking that
> the annotation works as intended by building with --nocheck and
> comparing results with diffoscope."
> 
> So I tested this by:
> 
> 
> $ export DEB_BUILD_OPTIONS=nocheck
Errata:
This is export DEB_BUILD_PROFILES="nocheck"
> $ export DEB_BUILD_OPTIONS="nocheck"
> $ gbp buildpackage
> $ mv ../python3-pylsp_1.13.2-1_all.deb ../profiles/nocheck
> $ unset DEB_BUILD_OPTIONS
> $ unset DEB_BUILD_PROFILES
> $ gbp buildpackage
> $ mv ../python3-pylsp_1.13.2-1_all.deb ../profiles/default
> $ cd ../profiles
> $ diffoscope default/python3-pylsp_1.13.2-1_all.deb nocheck/python3-
> pylsp_1.13.2-1_all.deb
> $ echo $0
> 0
> 
> Is this the test you were referring too?
> 
> 1. hhttps://wiki.debian.org/qa.debian.org/FTBFS/nocheck
> 2.
> https://lists.debian.org/debian-devel-announce/2022/10/msg00004.html