review for ffmpeg-normalize/1.33.3+ds-1

Jeroen Ploemen <[email protected]> Fri, 28 Nov 2025 11:13:58 -0000

Newsgroups	gmane.linux.debian.devel.python
Message-ID	<[email protected]>

hi Alex,

I took a look at the ffmpeg-normalize package, up for sponsorship in
the Python team.

The current package design has a tiny binary package than contains
only a launcher script split off from the module. Is there any real
life use of the module as such, or is this really an application that
just happens to be written in Python? Even the parsing of the command
line arguments for the util is actually done inside the module, which
strongly hints at the latter.

Then a couple of notes and questions regarding the packaging:
* control: no dependency of any kind on ffmpeg? The very first step
  of the "quick start" in upstream's readme file is "install a recent
  version of ffmpeg".

* control: you probably want to suggest the documentation pkg
  somewhere.

* copyright: "Upstream-Name: ffmpeg-progress-yield", copy-paste error?

* copyright: why the exclusions for dfsg-compliant stuff, that gets
  regenerated on build anyway? Wouldn't a regular d/clean entry
  suffice if one wants to make sure never to use the pre-generated
  files?


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

signature.asc (application/pgp-signature, 833 B)