review for python-pytooling/8.8.0-1

Jeroen Ploemen <[email protected]> Tue, 9 Dec 2025 16:58:11 -0000
Newsgroups	gmane.linux.debian.devel.python
Message-ID	<[email protected]>
hi Aryan,

I took a look at the python-pytooling package, up for sponsorship in
the Python team:

* repo: d/salsa-ci.yml exists but the CI wasn't enabled. Fixed already.

* copyright: missing a copyright holder for a bunch of files:
  pyTooling/CLIAbstraction/Command.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/ValuedFlag.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/Argument.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/ValuedFlagList.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/Flag.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/KeyValueFlag.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/ValuedTupleFlag.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/BooleanFlag.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/OptionalValuedFlag.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  pyTooling/CLIAbstraction/__init__.py:15:# Copyright 2014-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #
  tests/unit/CLIAbstraction/Executable.py:15:# Copyright 2007-2016 Technische Universität Dresden - Germany, Chair of VLSI-Design, Diagnostics and Architecture     #

* control: why is there a dependency on python3-all on the binary pkg?

* rules: tests are disabled wholesale, despite numerous test-specific
  build-deps and what looks like a pytest-based testsuite.

  I created a branch and enabled the unit tests [1], and that seems to
  work alright (on amd64 at least, see [2]). Benchmark and performance
  tests also worked locally, but progressed rather slowly so I left
  these off for now.

  The testsuite fails on i386 because of the extremely limited linux
  platform detection/support in pyTooling/Platform/__init__.py, lines
  247-257. That code looks like it can only ever work on amd64 and
  arm64. So unless it's possible to somehow add support for other
  archs, tests on build (as well as the autopkgtest) need to be
  limited to those two - for example by adding an override for
  dh_auto_test depending on the architecture, see [3].

  I'll leave the decision whether or not to enable tests to you.
  Please do comment out the testing-related build-deps if you decide
  to leave them off.

* autopkgtest: 'Testsuite: autopkgtest-pkg-pybuild' when no tests are
  run on build only creates the illusion of an autopkgtest. Please
  don't do that, it's basically the equivalent of running /bin/true.


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.


[1]https://salsa.debian.org/python-team/packages/python-pytooling/-/commit/ff8082ce38bff8da14ad113f3c3c3f0d5720a7ec
[2]https://salsa.debian.org/python-team/packages/python-pytooling/-/pipelines/987532
[3]https://codesearch.debian.net/search?q=path%3Adebian%2Frules%20filter.*DEB_HOST_ARCH&literal=0&perpkg=1
signature.asc (application/pgp-signature, 833 B)