Re: review for audio-visualizer-python/2.1.2-1

Jeroen Ploemen <[email protected]> Fri, 16 Jan 2026 10:48:37 -0000

Newsgroups	gmane.linux.debian.devel.python
Message-ID	<[email protected]>

On Fri, 16 Jan 2026 01:15:41 -0300
"Aeliton G. Silva" <[email protected]> wrote:

> I managed to include a autopkgtest that generates a video from
> tests/data/test.ogg and checks if the output is a video/mp4 using
> file.

To ensure the content of the extracted source package isn't somehow
still used in an unforseen way, you probably want to copy the input
.ogg over and change directory to $AUTOPKGTEST_TMP before running the
avp command. The goal of an autopkgtest is to test the installed
*.deb, not the sources.

Why does the autopkgtest need a dependency on python3-qtpy-pyqt6?

> So the last problem still standing is now to make avp be [installed]
> as a program.

Maybe the PYBUILD_INSTALL_ARGS only works with an actual setup.py, but
not with pyproject.toml? All I found was another maintainer with the
same problem, suggesting this could be a bug/limitation of pybuild
(see [1] for their comments and workaround). Please ask on the Python
Team IRC channel how to pull this off with PEP517/pyproject.toml,
maybe someone there knows a less hacky way.

Then there's build failure on i386, see CI results on salsa. Could be
the failing test is just taking longer on that arch than on amd64 and
gets cut off after 10 seconds? Note the "[libx264 @ 0x56bf84c0] using
cpu capabilities: none!" in the build log; the lack of hardware
acceleration could have a significant impact. Try patching the test to
make the timeout at least an order of magnitude longer.

And lastly a few minor lintian hits, "P: audio-visualizer-python
source: trailing-whitespace" about d/control that need to go as well.

[1]https://sources.debian.org/src/comitup/1.43-1/debian/rules?hl=29#L29-L43

signature.asc (application/pgp-signature, 833 B)