Re: review for python-pgvector/0.4.2-1

Arian Ott <[email protected]> Wed, 04 Mar 2026 07:24:58 +0000
Newsgroups gmane.linux.debian.devel.python
Organization IEEE
Message-ID <[email protected]>
Hi Jeroen,

sorry again for my late reply and thanks for your review.

In the current version most of the feedback should be implemented. 

On Monday, 23 February 2026 16:40:40 Greenwich Mean Time you wrote:
> hi Arian,
> 
> I took a look at the python-pgvector package, up for sponsorship in
> the Python team:
> 
> * there's diff between the orig tarball pulled in by uscan and the
>   one generated from the pristine-tar branch:
>   (output from tardiff -m -s)
> <snip>

I recreated the pristine-tar again and pushed it in the repo.



> * autopkgtest: please test with all supported Python versions. The
>   salsa CI logs show both 3.13 and 3.14 tested on build, but only
>   3.13 in the autopkgtest.

I added a for loop iterating over all python versions.
> 
> * patches: 0001 says 'forwarded: not needed' but looks like it
>   wouldn't do any harm upstream either?
> 

Upstream rejected all patches ¯\_(ツ)_/¯

See: 

https://github.com/pgvector/pgvector-python/pull/148
https://github.com/pgvector/pgvector-python/pull/149

Thanks again for your feedback.

Best,
-- 
Arian Ott
[email protected]
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQ570sfaLiVGcYRMsqsYaucMsJZ5gUCaafeSgAKCRCsYaucMsJZ
5i5XAQCHwl+lA1chvW3Vt7ZU5lB7JxSvviURPMJtKxVGxESSswEAn43R2FJ/mVv1
LGo0MBHJTaRd5AalE+707qXUSqivAAI=
=OX/f
-----END PGP SIGNATURE-----