review for beets/2.9.0-1

Jeroen Ploemen <[email protected]> Sun, 3 May 2026 15:49:21 -0000
Newsgroups	gmane.linux.debian.devel.python
Message-ID	<[email protected]>
hi Pieter,

my review for the beets package:

* control: very specific version requirement for the dependency on
  python3-acoustid (= 1.3.1), while the upstream pyproject.toml
  specifies ^1.3.1 (note the caret) which if IIRC translates to
  >=1.3.1,<2;
* control: the build-dep on sphinx <9 has been overtaken by reality,
  with sphinx/9.1.0-1 already in unstable. Build seems to be fine
  with 9.1.0 too though.

  For both of the above, it's often an open question whether version
  restrictions declared by upstream are actually hard requirements or
  just a matter of "we prefer to have everyone use the version we
  tested with".

* tests: d/tests/control declares the same dependencies and
  restrictions for both tests, but basic_cli_functions only really
  needs the "beet" binary and no optional extras or test
  dependencies. Please give that test a separate entry in
  d/t/control, with the dependencies trimmed down to just
  the binary package, restrictions adjusted so stderr is not
  permitted, and the test marked superficial.

* tests: because of "set -e" the last line of basic_cli_functions
  (printing the exit status) is only ever reached in case the 'beet
  -version' command succeeds which is probably not what you intended.

  If you remove that line so that 'beet --version' is the last
  command run, its exit status would determine the exit status of the
  script as a whole, which in turn is logged automatically by the
  autopkgtest runner.

  Alternatively, if you like the script to output the exit status, you
  could remove the "set -e", but then you'd have to store the exit
  status of the beet command and use that to explicitly set the exit
  status of the test (preventing the echo command from making the test
  always succeed). See [1] for an example of that approach (albeit
  for a different reason).


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

[1]https://salsa.debian.org/jcfp/python-rarfile/-/blob/e96ae5664fe1a3d59fe6f18dbbbc1a8c6ca8d43e/debian/tests/upstream-tests
signature.asc (application/pgp-signature, 833 B)