review for pymongo/4.17.0-1

Jeroen Ploemen <[email protected]> Tue, 12 May 2026 16:34:59 -0000
Newsgroups gmane.linux.debian.devel.python
Message-ID <[email protected]>
--Sig_/QAZXdJFn9+y5yoif.wzzCEw
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

hi Aryan,

my review for the pymongo package, up for sponsorship in the Python
team:

* changelog: removal of field from d/control not documented.

* copyright: missing info for pymongo/_asyncio_lock.py (PSF).
* copyright: upstream headers consistently assign copyright to
  "MongoDB, Inc.", with Mike Dirolf only mentioned as a
  contributor/author.

* rules: dh_compress is overridden to exempt html files from
  compression, which iirc is the default behaviour already.

* watch: still sets a repacksuffix, although one hasn't been used by
  this package since 2018.

* control: no dependencies of any kind on cryptography, OpenSSL,
  requests, service_identity; unconditional imports in various places
  in pymongo/ocsp_support.py, pyopenssl_context.py, ocsp_cache.py.
* control: a (suggested or recommended?) dependency on certifi could
  be useful for py3-pymongo, optional import at
  pymongo/pyopenssl_context.py:50; the same goes for kerberos,
  optional import at pymongo/synchronous/auth.py:63 as well as
  pymongo/asynchronous/auth.py:64


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

--Sig_/QAZXdJFn9+y5yoif.wzzCEw
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmoDVrMACgkQQoMEoXSN
zHrGyRAAw/uoJwnHyb5JkRydG9AWSW1OUFVE+9sQY/kX/iFJgJqtgDfyBB5hlRvo
NI2zr9vVtIVCORuxuU9XkWxlJ3K5QPfQGQJImJ5QQnMDWMDO550CvhkSHwr3U71G
SaD/4i+es/0EFFhbbEpwGRUwD76KUPS7Kwyikmzi1DykOp3t/kbGbBawmI8P6s7x
8xTBDAXxcr9jl60crNqU+pPGqzav/YqtLQ7ewzr1gnutkYS7XBZ5BGEqjq3W+LVP
RPni8JcxORdAs5vScBk0jXCcB5WwrcCRmGz5GXSsXlyQTNz35m01f66c7Ze0MH5z
beYeKkZk3EzsXriw7uw1bUJxWoPU7xcn2NPE66W67D/5c16uSeHSx3aVAHRSanwx
oydDZYEJY7EFK/KKragEBCSNB0WW4sZvar0HKyX/W1rAyKCYMARMFNZ2FIopx4x1
lNI1QyNS8bdPDcWguJFtWJ13KKrF20tqDriw6Qaq5UN16Z5weD1I1wa2avwwzliR
QDaZZYMkxWEUoFtY0t7749S5sZ0kTBV2B7gWVltfek3rlO/rnBviAIgi37zzFzpg
DPWbAGFIfDUIg2Krg2HE5nmthAwbTs9A/Q9RN+lwYmlzBNFe0X2TZxAFaRa9gPvP
5pZwPJFKdhOC4H32+dflj5qFxZYltbOmmNYJVct6Ny9ZkfvtQKY=
=VNGj
-----END PGP SIGNATURE-----

--Sig_/QAZXdJFn9+y5yoif.wzzCEw--