Re: review for python-pyvips/3.1.1-1

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------19323ac95d1fa4de816d477c9f5aeffb74ec61b7e7f2560f41705bdad72572e6
Content-Type: multipart/mixed;boundary=---------------------80ea01b1f2633f3ba4b3ef32ec57aafd

-----------------------80ea01b1f2633f3ba4b3ef32ec57aafd
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8

Thanks Jaroen,

thanks for the review. I have addressed the comments on debian/master in t=
he Python Team repository, commit ded83e2f1d8b38ced4fcbc280e8c7494b835d765=
.

  Point by point:

  - changelog/control: removed Mr. Modaresi from Uploaders and updated the=
 changelog trailer to Michele Cane.
  - control: added Built-Using: ${sphinxdoc:Built-Using} to python3-pyvips=
-doc.
  - examples: moved the examples from python3-pyvips to python3-pyvips-doc=
.
  - rules: made the test_from_numpy skip conditional on DEB_HOST_ARCH_BITS=
 =3D=3D 32, so it still runs on 64-bit architectures.
  - rules/control: honoured the nodoc profile for the Sphinx build and mar=
ked the documentation-only Build-Depends with <!nodoc>.
  - patches: I have kept the comment_get_documenter.patch for now and will=
 forward it upstream.
  - lintian: added a patch to remove the remote GitHub Actions badge from =
the generated documentation and removed the privacy-breach-generic overrid=
e.
  - pyvips/pyvips_build.py: this is the CFFI build script used via setup.p=
y; it is not needed at runtime. I removed it from the installed runtime pa=
ckage, so python3-pkgconfig remains only a build dependency.

  QA:

  - sbuild -d unstable passed on amd64.
  - Upstream tests passed for Python 3.13 and 3.14.
  - lintian --display-info --pedantic python-pyvips_3.1.1-1_amd64.changes =
reports only the Python dist-info top_level.txt informational tag.

Thanks

Mike

Michele Cane, PhD

On Sunday, 26 July 2026 at 19:09, Jeroen Ploemen <[email protected]> wrote:

> hi Mike,
> =


> I took a look at the python-pyvips package, up for sponsorship in the
> Python team:
> =


> * changelog/control: mr. Modaresi is still listed as uploader, but no
>   longer active as a Debian maintainer.
> =


> * control: missing Built-Using: ${sphinxdoc:Built-Using} on the
>   documentation package.
> =


> * examples: these currently get installed into the module package,
>   but probably belong in the documentation package. Examples are
>   after all a form of documentation.
> =


> * rules: if test_from_numpy is only problematic on 32bit archs,
>   setting the PYTEST_ADDOPTS variable could be made conditional on
>   that (so the test still runs on other archs). IIRC, the relevant
>   variable one could use is DEB_HOST_ARCH_BITS.
> =


> * rules/control: sphinx-build is called even if the 'nodoc' build
>   profile is used. Please honour the build profile (examples at [1]);
>   documentation-only build-dependencies could also be marked <!nodoc>.
> =


> * patches: the comment_get_documenter patch looks like it isn't
>   Debian-specific and thus could be forwarded upstream?
> =


> * lintian: privacy-breach-generic has been overridden, but lintian
>   identified a real issue (remote build status badge image, via
>   doc/README.rst:4). Please add a patch for that and remove the
>   override.
> =


> * what is pyvips/pyvips_build.py used for? Is it just part of the
>   build process via setup.py, and if so, does it need to be
>   installed? Asking since it's currently part of the module, but it
>   needs python3-pkgconfig which isn't a dependency of the binary
>   package (only a build-dep right now).
> =


> =


> Once the above comments have been addressed, simply re-add the
> package to the IRC channel topic and/or ping me by e-mail.
> =


> =


> [1]https://codesearch.debian.net/search?q=3Dpath%3Adebian%2Frules%20filt=
er%20nodoc&literal=3D1&perpkg=3D1
> =


-----------------------80ea01b1f2633f3ba4b3ef32ec57aafd
Content-Type: application/pgp-keys; filename="publickey - [email protected] - 0xC017295D.asc"; name="publickey - [email protected] - 0xC017295D.asc"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="publickey - [email protected] - 0xC017295D.asc"; name="publickey - [email protected] - 0xC017295D.asc"

LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgp4ak1FWWtyR1N4WUpLd1lCQkFI
YVJ3OEJBUWRBSVRTb0djUkJVZFZZQ2poazdlcE9WWDhtak9PRXFPelgKZjI0bUpWd1pLNDdOTDIx
cFkyaGxiR1V1WTJGdVpVQndjbTkwYjI0dWJXVWdQRzFwWTJobGJHVXVZMkZ1ClpVQndjbTkwYjI0
dWJXVSt3bzhFRUJZS0FDQUZBbUpLeGtzR0N3a0hDQU1DQkJVSUNnSUVGZ0lCQUFJWgpBUUliQXdJ
ZUFRQWhDUkNrUnNyaEZFd3NtaFloQk1BWEtWMW1SeDlFaEFxU1BxUkd5dUVVVEN5YVk3Z0EKL2lX
TEZadzMva1BycjZNTDQyMC9JeWdZNGlBbGZpNlZmVnd0ZkRQZ1FDak1BUURZZUtEeEtJSXpWckpQ
CmF6NVhvbCtpT0hzMFNKV0twb0FsdjIzZWV6Y3dBYzQ0QkdKS3hrc1NDaXNHQVFRQmwxVUJCUUVC
QjBEdQp4NkdOR1NTZXhKSEFUSWlIYU1zSGc0L2ZpeGJGb1NPZm96ZzZsQ1BZZFFNQkNBZkNlQVFZ
RmdnQUNRVUMKWWtyR1N3SWJEQUFoQ1JDa1JzcmhGRXdzbWhZaEJNQVhLVjFtUng5RWhBcVNQcVJH
eXVFVVRDeWFpSWdCCkFNdG4wMmloaGx5VnV1YXNUclZYbDdjdVpJelNLZ1ZyRkowUnpoMTZrOUE3
QVFEMkt0R2lSQ1BlalNOQQorS1lYYmJOcVU1OGlPQm5yWGVoOEE3MExobTZBQmc9PQo9LzF2dwot
LS0tLUVORCBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCg==
-----------------------80ea01b1f2633f3ba4b3ef32ec57aafd--

--------19323ac95d1fa4de816d477c9f5aeffb74ec61b7e7f2560f41705bdad72572e6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wrsEARYKAG0FgmpmUrgJEKRGyuEUTCyaRRQAAAAAABwAIHNhbHRAbm90YXRp
b25zLm9wZW5wZ3Bqcy5vcmeFJ6R/9roPSyjOIHf9ctCxtqVZGOBqW5SszhJA
TlGGbRYhBMAXKV1mRx9EhAqSPqRGyuEUTCyaAABV2AEAn9sBF8zCA3t99sCS
uSZmyiJnvrzDMdOy9FiDiLx9TDYBAM6fsjplIpyTU6m0edw0els5YtijEda4
cgEjduF0kGsM
=mltP
-----END PGP SIGNATURE-----


--------19323ac95d1fa4de816d477c9f5aeffb74ec61b7e7f2560f41705bdad72572e6--