Bug#1043043: UDD patches: marks Forwarded as invalid if not 'no', 'not-needed', 'yes' or URL

On Sun, 1 Oct 2023 22:32:54 +0100 Richard Lewis
<[email protected]> wrote:
> On Mon, 7 Aug 2023 01:19:38 +0200 Guillem Jover <[email protected]> wrote:
>
> > On Fri, 2023-08-04 at 23:35:27 -0300, David da Silva Polverari wrote:
>
> > > When using https://udd.debian.org/patches.cgi, I notice that whenever
> > > the Forwarded field contains anything other than "no", "not-needed",
> > > "yes" or an URL, it gets marked as invalid.
> >
>
> Even 'Forwarded: yes' is regarded as invalid - see here:
>
> https://udd.debian.org/patches.cgi?src=chkrootkit&version=0.58b-1
>
> the patches marked "invalid" have been sent upstream by email but, sadly,
> there is no upstream bug tracker or url , so no url to include.
>
> it looks like this comes from
> https://salsa.debian.org/qa/udd/-/blob/master/rimporters/patches.rb#206-222
>
> line 222 requires that 'Forwarded: yes' be accompanied by a 'Bug' field
> (and on line 208 the bug must be http(s) url). This seems stricter than
> DEP3 ("Any value other than "no" or "not-needed" means that the patch has
> been forwarded upstream. Ideally the value is an URL proving that it has
> been forwarded and where one can find more information about its inclusion
> status.")
>
> and then
> https://salsa.debian.org/qa/udd/-/blob/master/web/patches.cgi i assume
> renders these as invalid.

Please see https://salsa.debian.org/qa/udd/-/merge_requests/59 for one
approach to fixing this bug