Bug#1145580: trixie-pu: package at-spi2-core/2.56.2-1+deb13u2
Samuel Thibault <[email protected]>
| Newsgroups | gmane.linux.debian.devel.release |
|---|---|
| Organization | I am not organized |
| Message-ID | <ao3dUuUDJoxdrtWh__31706.6396398999$1787682336$gmane$org@end> |
Package: release.debian.org Severity: normal Tags: trixie X-Debbugs-Cc: [email protected] Control: affects -1 + src:at-spi2-core User: [email protected] Usertags: pu Hello, I have uploaded at-spi2-core/2.56.2-1+deb13u2 as proposed trixie update. [ Reason ] We would like to upload the attached changes to trixie to fix the usage of the atkversion.h header in C++ (not a regression). [ Impact ] In Trixie (and before), C++ programs cannot use functions from atkversion.h because it does not include the extern "C" { } marker. This poses problem for building on Trixie accessibility tools that need to adapt to different versions of atk. [ Tests ] This was tested manually. [ Risks ] The code change is very trivial. [ Checklist ] [X] *all* changes are documented in the d/changelog [X] I reviewed all changes and I approve them [X] attach debdiff against the package in (old)stable [X] the issue is verified as fixed in unstable [ Changes ] This just adds the glib-standard G_BEGIN_DECLS G_END_DECLS calls, like done upstream https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/219
patch
(text/plain, 2.4 KB)
diff -Nru at-spi2-core-2.56.2/debian/changelog at-spi2-core-2.56.2/debian/changelog --- at-spi2-core-2.56.2/debian/changelog 2025-11-20 01:55:38.000000000 +0100 +++ at-spi2-core-2.56.2/debian/changelog 2026-08-25 19:52:58.000000000 +0200 @@ -1,3 +1,11 @@ +at-spi2-core (2.56.2-1+deb13u2) trixie; urgency=medium + + [ Valentin Haudiquet ] + * patches/debian-atkversion-c-linkage.patch: Fix atkversion.h header for C++ + (Closes: #1145539) + + -- Samuel Thibault <[email protected]> Tue, 25 Aug 2026 19:52:58 +0200 + at-spi2-core (2.56.2-1+deb13u1) trixie; urgency=medium * patches/keyboard-group: Fix taking group into account for key events diff -Nru at-spi2-core-2.56.2/debian/patches/debian-atkversion-c-linkage.patch at-spi2-core-2.56.2/debian/patches/debian-atkversion-c-linkage.patch --- at-spi2-core-2.56.2/debian/patches/debian-atkversion-c-linkage.patch 1970-01-01 01:00:00.000000000 +0100 +++ at-spi2-core-2.56.2/debian/patches/debian-atkversion-c-linkage.patch 2026-08-25 19:51:55.000000000 +0200 @@ -0,0 +1,33 @@ +Author: Robert Ancell <[email protected]> +Date: Wed, 10 Dec 2025 11:02:20 +1300 +Subject: Fix atk_get_major_version etc not linking on C++ +Origin: upstream, commit:5ae24f981ddce448682d123fd71ff20329bdd014 +Applied-Upstream: 2.59.0, commit:5ae24f981ddce448682d123fd71ff20329bdd014 + +These failed because the version header was missing extern "C" (via +G_BEGIN_DECLS). +. +The atkversion.h header is missing G_BEGIN_DECLS/G_END_DECLS, causing +link failures when the header is included from C++ code. The version +functions (atk_get_major_version, atk_get_minor_version, etc.) are +declared without C linkage, so C++ consumers get mangled symbols that +do not match the C exports in libatk-1. + +--- a/atk/atkversion.h.in ++++ b/atk/atkversion.h.in +@@ -30,6 +30,8 @@ + + #include <glib.h> + ++G_BEGIN_DECLS ++ + /** + * ATK_MAJOR_VERSION: + * +@@ -473,4 +475,6 @@ guint atk_get_interface_age (void) G_GNUC_CONST; + #define atk_binary_age atk_get_binary_age () + #define atk_interface_age atk_get_interface_age () + ++G_END_DECLS ++ + #endif /* __ATK_VERSION_H__ */ diff -Nru at-spi2-core-2.56.2/debian/patches/series at-spi2-core-2.56.2/debian/patches/series --- at-spi2-core-2.56.2/debian/patches/series 2025-11-20 01:55:30.000000000 +0100 +++ at-spi2-core-2.56.2/debian/patches/series 2026-08-25 19:52:08.000000000 +0200 @@ -1,3 +1,4 @@ at-spi-by-default workaround_tests_issue.patch keyboard-group +debian-atkversion-c-linkage.patch