Bug#1053555: openssh-server: DebianBanner setting not shown in configuration dump

Rasmus Villemoes <[email protected]>
Newsgroups gmane.linux.debian.devel.ssh
Message-ID <3c718d0e-3624-c429-f5d7-c169b43cfd95__48819.8575958208$1696583401$gmane$org@rasmusvillemoes.dk>
Package: openssh-server
Version: 1:8.4p1-5+deb11u1
Severity: minor

Dear Maintainer,

'sshd -T', and since v9.3 also 'sshd -G', is supposed to print the
full, effective configuration. However, debian-banner.patch neglects
to update dump_config(), so there's no line showing the effective
value of the debianbanner setting.

I think the fix is as simple as adding

  dump_cfg_fmtint(sDebianBanner, o->debian_banner);

somewhere appropriate in dump_config().

IOW,

  sshd -T | grep ^debianbanner

produces nothing, but I'd expect it (in the default Debian
configuration) to print

  debianbanner yes

-- System Information:
Debian Release: 11.7
  APT prefers oldstable-updates
  APT policy: (500, 'oldstable-updates'), (500, 'oldstable-security'),
(500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-25-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8), LANGUAGE
not set
Shell: /bin/sh linked to /usr/bin/bash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages openssh-server depends on:
ii  adduser                3.118
ii  debconf [debconf-2.0]  1.5.77
ii  dpkg                   1.20.12
ii  libaudit1              1:3.0-2
ii  libc6                  2.31-13+deb11u7
ii  libcom-err2            1.46.2-2
ii  libcrypt1              1:4.4.18-4
ii  libgssapi-krb5-2       1.18.3-6+deb11u3
ii  libkrb5-3              1.18.3-6+deb11u3
ii  libpam-modules         1.4.0-9+deb11u1
ii  libpam-runtime         1.4.0-9+deb11u1
ii  libpam0g               1.4.0-9+deb11u1
ii  libselinux1            3.1-3
ii  libssl1.1              1.1.1n-0+deb11u5
ii  libsystemd0            247.3-7+deb11u4
ii  libwrap0               7.6.q-31
ii  lsb-base               11.1.0
ii  openssh-client         1:8.4p1-5+deb11u1
ii  openssh-sftp-server    1:8.4p1-5+deb11u1
ii  procps                 2:3.3.17-5
ii  runit-helper           2.10.3
ii  ucf                    3.0043
ii  zlib1g                 1:1.2.11.dfsg-2+deb11u2

Versions of packages openssh-server recommends:
ii  libpam-systemd [logind]  247.3-7+deb11u4
ii  ncurses-term             6.2+20201114-2+deb11u1
pn  xauth                    <none>

Versions of packages openssh-server suggests:
pn  molly-guard   <none>
pn  monkeysphere  <none>
pn  ssh-askpass   <none>
pn  ufw           <none>

-- debconf information excluded
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.