Bug#905440: www.debian.org: remove "last modified" from footer
Laura Arjona Reina <[email protected]>
| Newsgroups | gmane.linux.debian.devel.www |
|---|---|
| Message-ID | <f3a9f096-b43a-6480-0ed5-e958cec40441__21485.765631269$1534982839$gmane$org@debian.org> |
Hello all
El 22/08/18 a las 01:50, Steve McIntyre escribió:
>
> See https://salsa.debian.org/webmaster-team/webwml/merge_requests/21
> for a first attempt...
>
Thanks.
I've had a look to this and made some tests.
The layout and strings look fine for me. The POT/PO templates update well.
The pages seem to build well (I didn't build the whole website locally
but tried a good portion of /english and some other languages).
* Looking at the resulting times shown in the html pages, and
researching a bit, I found this in /devel/website/working:
---
GEN_TIME="true"
Sets the date on the resulting files to the timestamp of the
generated files, instead of the timestamp of the source file.
---
(I didn't know this existed)
This variable is considered, in the MR, only in the webwml_built_time
function (correct). The issue I see is that the variable is used in few
pages (see attached file containing a list of the English page that have
the variable set).
I am not sure how to go now from here; if reviewing which pages should
have the GEN_TIME="true" option in the header, or just forget about the
GEN_TIME variable (delete it in every page) and simplify the functions
in ctime.wml template to reuse the code that is run now when
GEN_VARIABLE is not present for the webwml_modified_time, and the code
that now is run when GEN_VARIABLE is present and has "yes", for the
webwml_built_time.
Note: there is some more code related to the GEN_VARIABLE in
/english/template/debian/footer.wml that we would need to adapt if we
decide to remove the variable.
Cheers
--
Laura Arjona Reina
https://wiki.debian.org/LauraArjona
list_GEN_TIME_yes.txt
(text/plain, 5.8 KB)
misc/merchandise.wml:1:#use wml::debian::template title="Debian Merchandise" GEN_TIME="yes" BARETITLE=true security/2015/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2016/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/1999/index.wml:2:#use wml::debian::template title="Security Advisories from 1999" GEN_TIME="yes" security/2018/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2014/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2003/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2008/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2012/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2004/CAN-2004-0109.wml:1:#use wml::debian::template title="Kernel Vulnerability Matrix for CAN-2004-0109" GEN_TIME="yes" security/2004/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2004/CAN-2004-0077.wml:1:#use wml::debian::template title="Kernel Vulnerability Matrix for CAN-2004-0077" GEN_TIME="yes" security/1997/index.wml:1:#use wml::debian::template title="Security Advisories from 1997" GEN_TIME="yes" security/2001/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2005/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/make-ref-table.pl:259:#use wml::debian::template title="Security Crossreferences" GEN_TIME="yes" security/1998/index.wml:2:#use wml::debian::template title="Security Advisories from 1998" GEN_TIME="yes" security/parse-advisory.pl:262: $index .= qq|#use wml::debian::template title="<pagetitle>" GEN_TIME="yes"\n|; security/crossreferences.wml:1:#use wml::debian::template title="Security Cross References" GEN_TIME="yes" NOHEADER="indeed" security/2007/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2013/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2000/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2002/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2011/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2010/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2009/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/index.wml:1:#use wml::debian::template title="Security Information" GEN_TIME="yes" security/2006/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/2017/index.wml:2:#use wml::debian::template title="<pagetitle>" GEN_TIME="yes" security/undated/index.wml:1:#use wml::debian::template title="Security Advisories from late '97 and early '98" GEN_TIME="yes" CD/vendors/index.wml:1:#use wml::debian::cdimage title="Vendors of Debian installation media" BARETITLE=true GEN_TIME=true doc/books.wml:1:#use wml::debian::template title="Debian Books" GEN_TIME="yes" devel/website/working.wml:197:<dt>GEN_TIME="true"</dt> devel/wnpp/being_packaged_byactivity.wml:1:#use wml::debian::template title="Packages being worked on, organized by activity" GEN_TIME="true" devel/wnpp/help_requested_byage.wml:1:#use wml::debian::template title="Packages for which help was requested, organized by age" GEN_TIME="true" devel/wnpp/being_adopted_byactivity.wml:1:#use wml::debian::template title="Packages currently being adopted, organized by activity" GEN_TIME="true" devel/wnpp/help_requested.wml:1:#use wml::debian::template title="Packages for which help was requested" GEN_TIME="true" devel/wnpp/rfa_bypackage.wml:1:#use wml::debian::template title="Packages up for adoption" GEN_TIME="true" devel/wnpp/orphaned.wml:1:#use wml::debian::template title="Orphaned packages" GEN_TIME="true" devel/wnpp/work_needing.wml:1:#use wml::debian::template title="Packages in need of a new maintainer" GEN_TIME="true" devel/wnpp/being_adopted.wml:1:#use wml::debian::template title="Packages currently being adopted" GEN_TIME="true" devel/wnpp/orphaned_byage.wml:1:#use wml::debian::template title="Orphaned packages, by age" GEN_TIME="true" devel/wnpp/rfa_bymaint.wml:1:#use wml::debian::template title="Packages up for adoption, organized by maintainer" GEN_TIME="true" devel/wnpp/requested.wml:1:#use wml::debian::template title="Requested packages" GEN_TIME="true" devel/wnpp/being_adopted_byage.wml:1:#use wml::debian::template title="Packages currently being adopted, organized by age" GEN_TIME="true" devel/wnpp/being_packaged_byage.wml:1:#use wml::debian::template title="Packages being worked on, organized by age" GEN_TIME="true" devel/wnpp/help_requested_bypop.wml:1:#use wml::debian::template title="Packages for which help was requested, organized by popularity" GEN_TIME="true" devel/wnpp/requested_byage.wml:1:#use wml::debian::template title="Requested packages, organized by age" GEN_TIME="true" devel/wnpp/being_packaged.wml:1:#use wml::debian::template title="Packages being worked on" GEN_TIME="true" devel/wnpp/rfa_byage.wml:1:#use wml::debian::template title="Packages up for adoption, organized by age" GEN_TIME="true" devel/wnpp/prospective.wml:1:#use wml::debian::template title="Prospective packages" GEN_TIME="true" devel/people.wml:1:#use wml::debian::template title="Project Participants" GEN_TIME="yes" y2k/extra.wml:1:#use wml::debian::template title="Debian and Y2K" GEN_TIME="yes" y2k/index.wml:1:#use wml::debian::template title="Debian and Y2K" GEN_TIME="yes" distrib/pre-installed.wml:1:#use wml::debian::template title="Computer vendors that pre-install Debian" GEN_TIME="yes" legal/licenses/index.wml:1:#use wml::debian::template title="License information" GEN_TIME="yes" legal/privacy.wml:1:#use wml::debian::template title="Privacy Policy" NOCOMMENTS="yes" GEN_TIME="yes"