Bug#947357: Bug #947357: votebar template fails at parsing some translated files

Alban Vidal <[email protected]> Thu, 2 Jan 2020 13:26:26 +0100

Newsgroups	gmane.linux.debian.devel.www
Message-ID	<f5f8c26b-2635-32ac-d4cb-2993be66c0d0__17481.6975997359$1577971286$gmane$org@zordhak.fr>

Hi Laura,

On Thu, 26 Dec 2019 22:31:36 +0100 Laura Arjona Reina
<[email protected]> wrote:

> I have noticed that the files not added in the Spanish index were the
> ones with the translation-check header in the first line. I have moved
> the translation-check header line below, so the first line is the
> pagetitle and the second line the status, and then the file is parsed
> correctly by the votebar template and thus, added to the index.
>
> So, I see 2 ways of solving the issue:
>
> * Fixing the Perl code in /english/template/debian/votebar.wml so it
> parses the title and status line wherever they are
>
> * Finding a list of the translated files not having the pagetitle and
> status lines as the first two lines in the file, and fixing them as I
> did with the Spanish ones, and adding a note to translators in future
> voting files so they move the translation-check header below (note that
> copypage.pl places this line at the top of the file).

All of files named 'vote_*.wml' now correctly start with:
line1: ^<define-tag pagetitle>
line2: ^<define-tag status>

Done by commit e7846f57 [1], thanks Jean-Pierre Giraud.
Votebar seem good on any languages.

Now I'll see to try to fix the Perl script (but I'm not Perl expert).

Best regards,
Alban

[1]
https://salsa.debian.org/webmaster-team/webwml/commit/e7846f578d3c3e61ec164111fa0569e6e8ca0d68

signature.asc (application/pgp-signature, 833 B)