Re: New development of how to build the installation-guide for the website [ Re: Bug#930846: partman-auto-lvm: debconf show guided_size during auto install ]

On Sat, 2020-01-04 at 15:44 +0100, Holger Wansing wrote:
> Hi,
> 
> Huh?
> I'm totally confused. See below...
> 
> "Adam D. Barratt" <[email protected]> wrote:
> > On Wed, 2020-01-01 at 19:52 +0100, Holger Wansing wrote:
> > > Hi,
> > > 
> > > Laura Arjona Reina <[email protected]> wrote:
> > > > Hi
> > > > 
> > > > The cron job will do the 'git pull' on wolkenstein the next
> > > > time it
> > > > runs.
> > > 
> > > yes, that worked, thanks.
> > > So, the build was performed via the new script, and thanks to
> > > that we
> > > now have the manual for buster on the webpage for buster :-)
> > > (the last two days there was the manual for bullseye there.)
> > > 
> > > Thus, that part works fine so far.
> > 
> > Only for languages up to and including Japanese (see below). A
> > number
> > of languages currently have no installation manual there.
> 
> Hmm. I wonder where you found this...
> I did not saw such build errors on
> https://www-master.debian.org/build-logs/webwml/

It's in /srv/www.debian.org/installmanual/buster.log on www-master, as
produced by the lessoften cron. I have no idea if that's exported.

> and looking here at
> https://www.debian.org/releases/stable/installmanual
> I see manuals for all languages and all formats available and
> correctly 
> displayed, including Korean pdf!

Yes, but:

-rw-rw-r-- 1 debwww debwww 565570 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.pdf.ko
-rw-rw-r-- 1 debwww debwww 467581 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.txt.ko
-rw-rw-r-- 1 debwww debwww 793159 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.pdf.nl
-rw-rw-r-- 1 debwww debwww 495077 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.txt.nl
-rw-rw-r-- 1 debwww debwww 734356 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.pdf.pt
-rw-rw-r-- 1 debwww debwww 453409 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.txt.pt
-rw-rw-r-- 1 debwww debwww 718640 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.pdf.ru
-rw-rw-r-- 1 debwww debwww 403421 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.txt.ru
-rw-rw-r-- 1 debwww debwww 719953 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.pdf.sv
-rw-rw-r-- 1 debwww debwww 433775 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.txt.sv
-rw-rw-r-- 1 debwww debwww 767819 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.pdf.vi
-rw-rw-r-- 1 debwww debwww 500863 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.txt.vi
-rw-rw-r-- 1 debwww debwww 612601 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.pdf.zh-cn
-rw-rw-r-- 1 debwww debwww 353216 Mar 24  2019 /srv/www.debian.org/www/releases/buster/i386/install.txt.zh-cn
-rw-rw-r-- 1 debwww debwww 693231 Jan  1 14:49 /srv/www.debian.org/www/releases/buster/i386/install.pdf.en
[etc]

[...]
> > > Makefile:8: recipe for target 'ko.i386' failed
> > make: *** [ko.i386] Error 2
> > </log>
> > 
> > buildweb.sh uses "set -e", so the failing Korean build causes the
> > script to abort, and the example-preseed.txt is never generated.
> > 
> > The build script on www-master, conversely, simply continues and
> > deploys whatever has been built up to that point.
> 
> As above, I am confused: 
> isn't the buildweb.sh script being used on www-master, triggered by
> the lessoften cron script I changed on 2020-01-01 ?

Yes, but I'm not sure how that disagrees with what I said.

The section I was referring to starts at 
https://sources.debian.org/src/installation-guide/20191229/build/buildweb.sh/#L51

If the "make" invocation there fails, the following preseed section
never gets run.

The lessoften script does:

	cd $ig_dir_stable/build &&
	manual_release=$stable_codename
destination=$webtopdir/installmanual/$stable_codename/ ./buildweb.sh >
$webtopdir/installmanual/$stable_codename.log 2>&1

	echo "copying $stable_codename installmanual in place..." >>
$crondir/log/lessoften.log
	rm -f $webdir/releases/$stable_codename/example-preseed.txt
	cp -a $webtopdir/installmanual/$stable_codename/*
$webdir/releases/$stable_codename/

without checking the result of the "make" invocation, so the partial
output from the new build is added to the already existing output from
the previous builds in releases/buster, as per the directory listing
earlier in this mail.

> Apparently I am missing something here ... (?)

Apparently so, or I failed at explaining clearly enough. :-)

Regards,

Adam