Re: New development of how to build the installation-guide for the website [ Re: Bug#930846: partman-auto-lvm: debconf show guided_size during auto install ]

Hi,

Holger Wansing <[email protected]> wrote:
> "Adam D. Barratt" <[email protected]> wrote:
> > On Sat, 2020-01-04 at 15:44 +0100, Holger Wansing wrote:
> > > > buildweb.sh uses "set -e", so the failing Korean build causes the
> > > > script to abort, and the example-preseed.txt is never generated.
> > > > 
> > > > The build script on www-master, conversely, simply continues and
> > > > deploys whatever has been built up to that point.
> > > 
> > > As above, I am confused: 
> > > isn't the buildweb.sh script being used on www-master, triggered by
> > > the lessoften cron script I changed on 2020-01-01 ?
> > 
> > Yes, but I'm not sure how that disagrees with what I said.
> > 
> > The section I was referring to starts at 
> > https://sources.debian.org/src/installation-guide/20191229/build/buildweb.sh/#L51
> > 
> > If the "make" invocation there fails, the following preseed section
> > never gets run.
> > 
> > The lessoften script does:
> > 
> > 	cd $ig_dir_stable/build &&
> > 	manual_release=$stable_codename
> > destination=$webtopdir/installmanual/$stable_codename/ ./buildweb.sh >
> > $webtopdir/installmanual/$stable_codename.log 2>&1
> > 
> > 	echo "copying $stable_codename installmanual in place..." >>
> > $crondir/log/lessoften.log
> > 	rm -f $webdir/releases/$stable_codename/example-preseed.txt
> > 	cp -a $webtopdir/installmanual/$stable_codename/*
> > $webdir/releases/$stable_codename/
> > 
> > without checking the result of the "make" invocation, so the partial
> > output from the new build is added to the already existing output from
> > the previous builds in releases/buster, as per the directory listing
> > earlier in this mail.
> 
> This part is of course an error of mine (means a problem in the lessoften
> cron script changed by me).
> 
> Will try to work on that these days.

I've fixed that now.
The built manual files are only copied to www dir, if the build was successful,
and I cleaned the www directory before copying, to avoid such mixup of files
from old and new versions in the future.
Also added an error to cron log in case of build error, to make the error
more visible.


(The above does not fix the build error and the current situation on the
website we already have, though.)


Holger