Re: Review for the non-free-firmware template in apt-setup

Holger Wansing <[email protected]> Sun, 22 Jan 2023 17:33:48 +0100
Newsgroups gmane.linux.debian.devel.boot,gmane.linux.debian.internationalization.english
Message-ID <[email protected]>
Hi,

Cyril Brulebois <[email protected]> wrote (Sun, 22 Jan 2023 16:24:12 +0100):
>     Template: apt-setup/non-free-firmware
>     Type: boolean
>     Default: false
>     # :sl5:
>     _Description: Use non-free firmware?
>      Some non-free firmware has been made to work with Debian. Though this
>      firmware is not at all a part of Debian, standard Debian tools can be used
>      to install it. This firmware has varying licenses which may prevent you
>      from using, modifying, or sharing it.
>      .
>      Please choose whether you want to have it available anyway.

Looks good to me (being not a native English speaker, though).

> I've selected sublevel 5 instead of sublevel 1, to make sure this isn't
> going to hurt the translation status (which localechooser uses to warn
> against incomplete translations at the very beginning of the
> installation process). Since that template is only shown in expert mode,
> and since we're adding /pretty late/ in the release cycle, I'd be happy
> to have translations if translators jump on it, and “sed” the non-free
> on into non-free-firmware, but we shouldn't block on this… I'll let
> Holger comment about that part and possibly propose different plans.

+1

Nothing more to add here from my side
Good work


Holger