Re: Bug#691097: Patch fails to apply

On Sun, 12 May 2013 13:52:03 +0200
Jakub Wilk <[email protected]> wrote:

> * Neil Williams <[email protected]>, 2013-05-12, 11:35:
> >Please provide the full .po file, not a patch. The current patch fails 
> >to apply against either gpdftext 0.1.5-1 from `apt-get source` or 
> >current SVN.
> >
> >patching file pl.po
> >Hunk #3 FAILED at 96.
> >Hunk #4 FAILED at 230.
> >2 out of 4 hunks FAILED -- saving rejects to file pl.po.rej
> 
> Well, it applies cleanly here against gpdftext-0.1.5-1 (and pl.po from 
> svn trunk r158 is identical):

The svn location has been transferred and is not yet up to date.

PO files are not like most source code - there is embedded generated
data which often causes patches to fail. Patches for PO files are
frequently useless.

> The attached .po is different than the one in svn, so I'm a bit 
> confused. Is that intentional? 

Of course it is. This will be a new upstream release, as with many
runtime PO translations. This isn't debconf. That is why the patch is
unhelpful.

> Anyway, my patch still applies to it:
> 
> $ zcat ~/fix-pl.po.diff.gz | patch -p1 pl.po --verbose

Only the file originally attached to the email - the file I downloaded
from the BTS failed to apply.

> >It would be a lot better to complete the translation
> 
> Sorry, I'm not interested in translating new stuff. I'm only interested 
> in fixing bugs in existing translations.

It really isn't a lot of work to add a few untranslated strings or at
least coordinate with the existing Polish translator with regard to the
errors in his translation. Missing and fuzzy strings *are* bugs in
existing translations.

Attaching the patched pl.po for the benefit of the existing translators
in the hope of getting *someone* to provide a correct and fully
translated PO file for gpdftext in Polish. Please send to
[email protected] for inclusion into the next upstream release.

pl: 41 translated messages, 6 fuzzy translations, 4 untranslated
messages.

Jakub: If you are going to file bugs about existing translations,
*please* always coordinate with the Last-Translator explicitly set in
every PO file *and* supply a full PO file, *not* a patch.

If you are not willing to do this, please confine your l10n "error
fixes" to the [email protected] list so that the complete PO
file can be sent to the maintainers.

There are very good reasons why l10n teams in Debian only work on the
basis of complete PO files, not patches.

-- 


Neil Williams
=============
http://www.linux.codehelp.co.uk/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRj9dOAAoJEPFn5DyBQ7aCrZAQANCjOp2IaMfqit02RkMsNBJr
rc9U5zfqdeJULD1UboxwD08utqGDUBtLPcHqHqAF4E6IshLDoyCAR5dqWaOo18N6
ojysqEtmkseneI19Dml9yDfDMrdLIsOGm0tBxQ/4lyYx/o/Zxu0DD0qHf7AIigk7
auyRUagdGIlpeWNmpcrAYU7zK6KAt82gUsety5DnlllGEm/IVv9op5twkUr1my1I
rpdwgR2qxyaBaopNJSrmUk29TWghjDj5hQUoD7dOdpFXRpV4ySRWtH8otd1krgwC
3co2veY7KGj/fATs3oHXhXtScYS7Av5/qILWl5UP6beA3VR9ONV4idEU2ep3fDu/
Dv6Cjb937DUzilDs9HRj2KoXZSRF3oIP1VsRQMZDdnH+S26e0ZXeKGWWmYdgwQYR
NyE7n6BdGKWawvcGSf69xdB2BV1nCmqz9sdt65nvULZHKZPTeEUyh7N+ZR471GXg
Zko1tL/SE0tHdHMho8WKrfzJkWENipQk9OUXoHPitxQ3mvbUk0pU6TlJf5KY+cjp
q1M1VVGwDhYtAs1emB2JNb5TKtgRMLsCdyCaUw7WqWepBr1kJQuDQBHX6OjmUTyl
StbCU7rE9yen9g7erqcDcW3i6C2daCj7A7zjFDYXaPiYzDhivkc+msEftlosIi4/
sWpDl6/hnQGcZ3g7Y1Uf
=/v8g
-----END PGP SIGNATURE-----