Re: bootstra.tos broken on 68040/68060 real hardware

Hi Michael, Miro,

Thanks for your patches!

On Sat, 8 Aug 2026 at 05:12, Michael Schmitz <[email protected]> wrote:
> haven't run these through checkpatch yet but at first glance they look good to me.

ERROR: Missing Signed-off-by: line(s)

> Patches 1,2 and 5 look uncontroversial enough. 3 and 4 might need more thorough review by fbdev maintainers.

Patch 1:

Fixes: 3bc753c06dd02a35 ("kbuild: treat char as always unsigned")

I am wondering if atamouse_interrupt() should be changed to
take a signed char instead, or perhaps a struct pointer?
The processing of keyboard_state is already quite complicated, though.

Patch 2:

I guess the comment should become the patch description, which
is currently empty?

Patches 4 and 5 lack patch descriptions, too.

Gr{oetje,eeting}s,

                        Geert