Bug#950635: guile-3.0: Please include patch to fix build on hppa

John Paul Adrian Glaubitz <[email protected]>
Newsgroups gmane.linux.debian.ports.hppa
Message-ID <158081798034.3333684.9346891471158517183.reportbug__28793.310425111$1580818166$gmane$org@z6.physik.fu-berlin.de>
Source: guile-3.0
Severity: normal
Tags: patch
User: [email protected]
Usertags: hppa

Hi!

The build of guile-3.0 on hppa currently fails with:

continuations.c: In function 'scm_dynthrow':
continuations.c:326:5: error: too few arguments to function 'grow_stack'
  326 |     grow_stack (cont);
      |     ^~~~~~~~~~
continuations.c:276:1: note: declared here
  276 | grow_stack (SCM cont, uint8_t *mra)
      | ^~~~~~~~~~
make[4]: *** [Makefile:2857: libguile_3.0_la-continuations.lo] Error 1

This is a regression in 3.0 and simply fixed by the attached patch which I have
also sent upstream [2]. Please include it in the next upload.

Thanks,
Adrian

> [1] https://buildd.debian.org/status/fetch.php?pkg=guile-3.0&arch=hppa&ver=3.0.0%2B1-1&stamp=1580702308&raw=0
> [2] https://lists.gnu.org/archive/html/guile-devel/2020-02/msg00017.html

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
0001-Fix-build-of-platforms-where-the-stack-grows-upwards.patch (text/plain, 884 B)
>From 9081d45472709b27f36a6b7f4be47e88f956a190 Mon Sep 17 00:00:00 2001
From: John Paul Adrian Glaubitz <[email protected]>
Date: Tue, 4 Feb 2020 12:12:24 +0100
Subject: [PATCH] Fix build of platforms where the stack grows upwards

 * libguile/continuations.c (scm_dynthrow): Fix missing mra
   parameter to grow_stack for SCM_STACK_GROWS_UP.
---
 libguile/continuations.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libguile/continuations.c b/libguile/continuations.c
index 3f86c6bd4..67a47d38c 100644
--- a/libguile/continuations.c
+++ b/libguile/continuations.c
@@ -323,7 +323,7 @@ scm_dynthrow (SCM cont, uint8_t *mra)
 
 #if SCM_STACK_GROWS_UP
   if (dst + continuation->num_stack_items >= &stack_top_element)
-    grow_stack (cont);
+    grow_stack (cont, mra);
 #else
   dst -= continuation->num_stack_items;
   if (dst <= &stack_top_element)
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.