Re: git: test suite fails on hppa, in run_with_limited_stack
John David Anglin <[email protected]>
| Newsgroups | gmane.linux.debian.ports.hppa |
|---|---|
| Message-ID | <[email protected]> |
On 2020-05-15 11:52 p.m., Greg Price wrote: > Still I'm not sure that that situation is helped by putting the `uname > -m` inside this case. This is the catchall `*)` case after looking > only for MINGW, CYGWIN, and FreeBSD, and those all appear to have > pretty sane `uname -m` behavior. (On FreeBSD, `uname -p` gets a bit > more specific but `uname -m` is already sane; I found the report here: > https://github.com/mesonbuild/meson/issues/5766 > informative.) If any of the OSes where config.guess has to do more > work were to get this far in building and testing Git, they'd end up > running any code we stick at this spot anyway. So I think it still > makes more sense to put the new `case` next to the existing one. > > One other thought I have from that config.guess example, though -- > there are some cases there like this: > > parisc64:Linux:*:* | hppa64:Linux:*:*) > echo hppa64-unknown-linux-"$LIBC" > exit ;; > > That suggests to me that the condition should perhaps look for "hppa", too, like > > parisc* | hppa*) > test_set_prereq HPPA > ;; > > What do you think? I think that's fine. Because git is important, Helge and I have been building it manually and largely ignoring test failures. This will help distinguish architectural limitations from new bugs. Regards, Dave