Re: Bug#1132024: Add insserv-bin binary package with /usr/libexec/insserv for easily creating Hurd chroots

Johannes Schauer Marin Rodrigues <[email protected]> Thu, 23 Apr 2026 15:19:59 +0200

Newsgroups	gmane.linux.debian.ports.hurd
Message-ID	<177695039983.3305.6195528840905540213@localhost>

Hi Mark,

Quoting Mark Hindley (2026-04-15 20:29:03)
> On Tue, Apr 14, 2026 at 03:09:46PM +0200, Johannes Schauer Marin Rodrigues
> wrote:
> > I changed my patch to this:
> > 
> > --- a/script/update-rc.d
> > +++ b/script/update-rc.d
> > @@ -192,6 +192,10 @@ sub create_sequence {
> >      $insserv = "/sbin/insserv" if ( -x "$dpkg_root/sbin/insserv");
> >      # If insserv is not configured it is not fully installed
> >      my $insserv_installed = -x "$dpkg_root$insserv" && -e "$dpkg_root/etc/insserv.conf";
> > +    # Ignore the presence of insserv if this system is using systemd as init
> > +    if ($insserv_installed && readlink "$dpkg_root/usr/sbin/init" eq "../lib/systemd/systemd") {
> > +        $insserv_installed = 0;
> > +    }
> >      my @opts;
> >      push(@opts, '-f') if $force;
> >      # Add force flag if initscripts is not installed
> 
> This looks sane to me. Obviously the readlink test could be combined with the my
> declaration:
> 
>      my $insserv_installed = -x "$dpkg_root$insserv" &&
>      -e "$dpkg_root/etc/insserv.conf" &&
>      readlink "$dpkg_root/usr/sbin/init" ne "../lib/systemd/systemd";
> 
> But that is just sugar.

yes, either would work fine.

> > What else do I have to check?
> 
> LGTM.
> 
> Thanks for taking this on.

What do you imagine would be the next steps? Where does this hang now?

Thanks!

cheers, josch

signature.asc (application/pgp-signature, 833 B)