Re: Important packages that are broken ia64

On 18.09.23 22:56, Frank Scheiner wrote:
> On 18.09.23 22:42, John Paul Adrian Glaubitz wrote:
>> On Mon, 2023-09-18 at 22:36 +0200, Frank Scheiner wrote:
>>>> I don't think this patch is acceptable in its current form as it
>>>> modifies the Makefile globally so that the flag is passed on to
>>>> the host compiler for all architectures.
>>>
>>> Yes, thought about that, too. Know a better solution? Is there a way to
>>> make this only affecting compilations for ia64?
>>
>> You could modify CFLAGS globally in debian/rules specifically for ia64:
>>
>> ifneq (,$(filter $(DEB_HOST_ARCH),ia64))
>> export DEB_CFLAGS_MAINT_APPEND += -fno-var-tracking
>> endif
>
> That's the other extreme then, everything for ia64 gets compiled with
> `-fno-var-tracking`, or? Is that more acceptable?
>
> Maybe the per-file CFLAGS are also effective when included in the
> architecture Makefile in `arch/ia64/`?
>
> Or maybe we could query the arch from within the two Makefiles and only
> apply `-fno-var-tracking` when we compile for ia64.
>
> I'll have a look into that tomorrow.

The MR ([1]) was updated and now uses `-fno-var-tracking` for the
respective files only when the target architecture is ia64. This works
like so for example:

```
ifeq ($(ARCH),ia64)
         CFLAGS_bnx2x_sp.o += -fno-var-tracking
endif
```

Tested via a local kernel build where one case was using a wrong target
architecture (i386) at first to see it failing and then working after
changing that back to the correct target architecture (ia64).

[1]: https://salsa.debian.org/kernel-team/linux/-/merge_requests/852

Cheers,
Frank