Re: Bug#1063446: libmozjs-115-dev: cannot call JS::CanonicalizeNaN(double) on mips64el
Simon McVittie <[email protected]> Thu, 8 Feb 2024 20:59:26 +0000
| Newsgroups | gmane.linux.debian.ports.mips,gmane.linux.debian.devel.wb-team |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 08 Feb 2024 at 10:37:33 +0000, Simon McVittie wrote:
> Package: libmozjs-115-dev
> Justification: makes gjs FTBFS (#1063433)
I believe mozjs115_115.7.0-3 should fix this.
wb-team: Please could someone with wanna-build access schedule gjs
on mips64el to be built after the fixed version of mozjs115 becomes
available? I believe the correct spelling is:
dw gjs_1.78.3-1 . unstable . mips64el . -m 'libmozjs-115-dev (>= 115.7.0-3)'
mips team, or mozjs experts: Please could someone look into upstreaming
the attached mips-specific patch?
Thanks,
smcv
Export-js-detail-CanonicalizedNaNBits-on-architectures-th.patch
(text/x-diff, 915 B)
From: Simon McVittie <[email protected]> Date: Thu, 8 Feb 2024 10:36:53 +0000 Subject: Export js::detail::CanonicalizedNaNBits on architectures that use it Otherwise the inline function JS::CanonicalizeNaN(double), which is called by gjs, cannot validly refer to it. Bug-Debian: https://bugs.debian.org/1063446 Signed-off-by: Simon McVittie <[email protected]> --- js/public/Value.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/public/Value.h b/js/public/Value.h index de8db0f..d934b59 100644 --- a/js/public/Value.h +++ b/js/public/Value.h @@ -445,7 +445,7 @@ constexpr uint64_t CanonicalizedNaNSignificand = 0x8000000000000; #endif #if defined(JS_RUNTIME_CANONICAL_NAN) -extern uint64_t CanonicalizedNaNBits; +extern JS_PUBLIC_DATA uint64_t CanonicalizedNaNBits; #else constexpr uint64_t CanonicalizedNaNBits = mozilla::SpecificNaNBits<double, detail::CanonicalizedNaNSignBit,