Re: Bug#1070042: libarchive: archive_entry_stat returns zero size on mips64el with _FILE_OFFSET_BITS=64
"Theodore Ts'o" <[email protected]> Tue, 30 Apr 2024 12:58:40 -0400
| Newsgroups | gmane.linux.debian.ports.mips |
|---|---|
| Message-ID | <[email protected]> |
reassign 1070042 e2fsprogs 1.47.1~rc1-1 retitle mke2fs -d foo.tar is broken on mips64el thanks On Tue, Apr 30, 2024 at 11:12:36AM +0300, Peter Pentchev wrote: > > AC_SYS_LARGEFILE was added to e2fsprogs configure.ac 2 years ago, > > therefore manual > > #define _FILE_OFFSET_BITS 64 > > #define _LARGEFILE64_SOURCE 1 > > should no longer be necessary for architectures where it is needed. > > Yeah, I think that's what Helmut Grohne said in #1068251, I knew I had > seen it before. So IMHO the problem here is indeed not in libarchive, but, > yes, in e2fsprogs setting FILE_OFFSET_BITS=64 unconditionally. > > As such, if no one objects, I think this bug should be closed and > e2fsprogs should indeed rely on AC_SYS_LARGEFILE (as libarchive already does) > instead. Thanks for the analysis! I've reassigned this bug to e2fsprogs and I will fix it on my end. Cheers, - Ted