Re: Bug#861171: #warning "Consider adding the right clone() syscall definitions here!"

Control: tags -1 patch

On Wed, May 3, 2017 at 11:10 AM, James Cowgill <[email protected]> wrote:
> Control: forwarded -1 https://github.com/systemd/systemd/pull/5880
>
> Hi,
>
> On 25/04/17 12:55, Michael Biebl wrote:
>> Am 25.04.2017 um 12:56 schrieb Mathieu Malaterre:
>>> Package: systemd
>>> Version: 232-22
>>> User: [email protected]
>>> Usertags: mipsel mips64el mips
>>>
>>> There are warning(s) generated during systemd building on mipsel* :
>>>
>>> I am starring at the clone warning (mmap seems to trigger something
>>> equivalent apparently):
>>>
>>> https://buildd.debian.org/status/fetch.php?pkg=systemd&arch=mips64el&ver=232-22&stamp=1490743348&raw=0
>>>
>>> See:
>>> http://sources.debian.net/src/systemd/232-22/src/shared/seccomp-util.c/#L726
>>>
>>>
>>> $ man 2 clone
>>> [...]
>>>        On x86-32, and several other common architectures (including
>>> score, ARM, ARM 64, PA-RISC, arc, Power PC, xtensa, and MIPS), the
>>> order of the last two arguments is reversed:
>>>
>>>            long clone(unsigned long flags, void *child_stack,
>>>                      int *ptid, unsigned long newtls,
>>>                      int *ctid);
>>> [...]
>>>
>>> I believe it would make sense to fix those warnings (missing case in
>>> the switch) for mips/arm & powerpc* family since those are release
>>> archs.
>>
>> Would be great if you can send us a tested patch. I don't have any mips*
>> hardware where I could test if the patch works as expected.
>
> I've tested and submitted an upstream PR for the MIPS support.

Nice ! Thanks for doing it.