Re: Bug#1105086: firefox: Please disable wasm sandboxing on ppc64

John Paul Adrian Glaubitz <[email protected]>
Newsgroups gmane.linux.debian.ports.powerpc,gmane.linux.debian.ports.sparc
Message-ID <b597cbc17fb650f13fdfc0712752c26afb81b70d.camel@physik.fu-berlin.de>
Hi,

On Mon, 2025-05-12 at 09:58 +0200, John Paul Adrian Glaubitz wrote:
> On Mon, 2025-05-12 at 09:25 +0200, John Paul Adrian Glaubitz wrote:
> > On Sat, 2025-05-10 at 23:03 +0200, John Paul Adrian Glaubitz wrote:
> > > This can be fixed by disabling wasm sandboxing similar to s390x [1]. Thus, please
> > > disable wasm sandboxing on ppc64 (see attached patch). Might even be a good idea
> > > to disable it for all big-endian targets.
> > 
> > In fact, please replace "DEB_HOST_ARCH == s390x" with "DEB_BUILD_ARCH_ENDIAN = big"
> > as this will also address the issue on sparc64 which I would like to build later.
> 
> I meant "DEB_BUILD_ARCH_ENDIAN == big", of course.

Attaching a tested patch. Also replacing DEB_BUILD_ARCH_ENDIAN with DEB_HOST_ARCH_ENDIAN.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
firefox-disable-wasm-sandboxing-bigendian.diff (text/x-patch, 2 KB)
diff -Nru debian.orig/browser.mozconfig.in debian/browser.mozconfig.in
--- debian.orig/browser.mozconfig.in	2025-05-02 01:00:21.000000000 +0000
+++ debian/browser.mozconfig.in	2025-05-13 12:19:40.319674499 +0000
@@ -30,6 +30,6 @@
 ac_add_options --with-unsigned-addon-scopes=app,system
 ac_add_options --allow-addon-sideload
 ac_add_options --enable-alsa
-%if DIST == bullseye || DEB_HOST_ARCH == s390x
+%if DIST == bullseye || DEB_HOST_ARCH_ENDIAN == big
 ac_add_options --without-wasm-sandboxed-libraries
 %endif
diff -Nru debian.orig/rules debian/rules
--- debian.orig/rules	2025-05-02 01:00:21.000000000 +0000
+++ debian/rules	2025-05-13 12:21:38.123608885 +0000
@@ -15,6 +15,7 @@
 $(call lazy,DEB_BUILD_ARCH_BITS,$$(shell dpkg-architecture -qDEB_BUILD_ARCH_BITS))
 $(call lazy,DEB_BUILD_ARCH,$$(shell dpkg-architecture -qDEB_BUILD_ARCH))
 $(call lazy,DEB_HOST_ARCH,$$(shell dpkg-architecture -qDEB_HOST_ARCH))
+$(call lazy,DEB_HOST_ARCH_ENDIAN,$$(shell dpkg-architecture -qDEB_HOST_ARCH_ENDIAN))
 
 PYTHON := PYTHONDONTWRITEBYTECODE=y python3
 
@@ -185,7 +186,7 @@
 stamps/mozbuild-state::
 	MOZ_OBJDIR=debian/objdir MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE=none $(PYTHON) ./mach python --virtualenv build -c ""
 
-$(PREPROCESSED_FILES): VARS = GRE_VERSION PRODUCT_DOWNLOAD_NAME $(PRODUCT) $(call uc,$(PRODUCT)) $(Product) MOZ_APP_REMOTINGNAME $(SYSTEM_LIBS_VARS) SHORT_SOURCE_CHANNEL DIST MOZ_ENABLE_V4L2 CRASH_REPORTER DEB_HOST_ARCH
+$(PREPROCESSED_FILES): VARS = GRE_VERSION PRODUCT_DOWNLOAD_NAME $(PRODUCT) $(call uc,$(PRODUCT)) $(Product) MOZ_APP_REMOTINGNAME $(SYSTEM_LIBS_VARS) SHORT_SOURCE_CHANNEL DIST MOZ_ENABLE_V4L2 CRASH_REPORTER DEB_HOST_ARCH DEB_HOST_ARCH_ENDIAN
 debian/control: VARS += L10N_PACKAGES_DEPS PRODUCT LIBAVCODEC
 $(PREPROCESSED_FILES):
 	MOZ_OBJDIR=debian/objdir MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE=none $(PYTHON) ./mach python --virtualenv build python/mozbuild/mozbuild/preprocessor.py --marker % -Fsubstitution $(foreach var,$(VARS),-D$(var)="$($(var))" )$< -o $@
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.