Re: [PATCH] fix for review

Hello Dima,

Thanks for testing it against 5.4.

yeah, its correct there is no formal policy/document stating that but in 
practice Lua 5.3 is most widely used stable release. There are some Lua 
libs in debian still tested primarily against 5.3. In Lua 5.4, there 
were *some language-level *changes (like to GC behaviour. Reference: 
https://www.lua.org/manual/5.4/manual.html#8) that can cause subtle 
breakage with older modules. So, I thought to use 5.3 to avoid any 
runtime breakage.

There are some API changes as well. So, I would suggest if we are going 
with 5.4 we should test runtime positive and negative scenarios as well.

On 01/09/25 01:33, Dima Kogan wrote:
> Hi. I just ran a few tests, and fixed something related. For sysdig,
> lua5.3 appears to work for multiple architectures, as you say. I also
> tried lua5.4, which also appears to work. 5.4 is greater than 5.3. Is
> there a reason to stick to 5.3 instead of moving up to 5.4? You said
>
>    5.3 is the default version of Lua in Debian for general-purpose use
>
> Is this the reason? I don't see any package dependency that says this.
> Is there some policy note or something that suggests that 5.3 is the
> default?
>
> Once we decide this, I'll check one more thing, and make the upload.
>
> Thanks for pushing on this.
>