Re: Fwd: Re: Bug#1115385: vlc: FTBFS on powerpc architecture

On Tue, 2025-09-16 at 17:17 +0700, Jeroen Diederen wrote:
> My apologies, I did the diff the wrong way. This is the correct one.
> 
> diff -Nru vlc-3.0.21/debian/rules vlc-3.0.21/debian/rules
> --- vlc-3.0.21/debian/rules	2025-08-23 20:15:15.000000000 +0700
> +++ vlc-3.0.21/debian/rules	2025-09-15 21:50:45.000000000 +0700
> @@ -250,13 +250,10 @@
>   removeplugins += neon
>   endif
> 
> -# PowerPC specific optimizations (excluding powerpcspe)
> -ifeq (,$(filter-out powerpc,$(DEB_HOST_ARCH_CPU))$(filter 
> powerpcspe,$(DEB_HOST_ARCH)))
> -confflags += --enable-altivec
> -else
> +# PowerPC build fo e5500 with altivec disabled
>   confflags += --disable-altivec
>   removeplugins += altivec
> -endif
> +

Passing --disable-altivec unconditionally would also disable it on ppc64el
which is a NAK.

I also think we should start a survey to find out whether there is actually
a significant number of users with PowerPC machines not capable of AltiVec
as disabling it causes a significant performance hit for targets which support
it.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913