Re: Bug#1115385: vlc: FTBFS on powerpc architecture

On Wed, 2025-09-17 at 13:13 +0200, John Paul Adrian Glaubitz wrote:
> On Wed, 2025-09-17 at 12:42 +0200, John Paul Adrian Glaubitz wrote:
> > On Wed, 2025-09-17 at 16:58 +0700, Jeroen Diederen wrote:
> > > You should try to build it in a ppc64el chroot. I think it will fail 
> > > because of altivec. The previous versions of vlc for ppc64el were built 
> > > without altivec enabled, or am I wrong?
> > 
> > Debian's ppc64el baseline supports baseline, so it should work:
> > 
> > (sid_ppc64el-dchroot)glaubitz@platti:~$ echo | gcc -E -dM -|grep -i altivec
> > #define __ALTIVEC__ 1
> > #define __pixel __attribute__((altivec(pixel__))) unsigned short
> > #define __vector __attribute__((altivec(vector__)))
> > #define __bool __attribute__((altivec(bool__))) unsigned
> > #define __APPLE_ALTIVEC__ 1
> > (sid_ppc64el-dchroot)glaubitz@platti:~$
> > 
> > The fact that it was not previously enabled is a bug.
> > 
> > I will perform a test build now.
> 
> vlc builds fine on ppc64el with AltiVec enabled after fixing the typo
> in my patch (missing last parenthesis). I will test powerpc and ppc64
> as well.

Both powerpc and ppc64 build fine as well, so the patch is fine once the
missing parenthesis is fixed. I'm attaching a fixed version of it.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- debian/rules.orig	2025-08-23 15:15:15.000000000 +0200
+++ debian/rules	2025-09-17 11:35:04.464027648 +0200
@@ -250,8 +250,9 @@
 removeplugins += neon
 endif
 
-# PowerPC specific optimizations (excluding powerpcspe)
-ifeq (,$(filter-out powerpc,$(DEB_HOST_ARCH_CPU))$(filter powerpcspe,$(DEB_HOST_ARCH)))
+# PowerPC specific optimizations
+# AltiVec is currently disabled on powerpc and ppc64
+ifeq (,$(filter-out ppc64el,$(DEB_HOST_ARCH_CPU)))
 confflags += --enable-altivec
 else
 confflags += --disable-altivec